Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

HP-UX build needs to be tweaked to pick up PATH_MAX #60039

Closed
tpn opened this issue Aug 31, 2012 · 5 comments
Closed

HP-UX build needs to be tweaked to pick up PATH_MAX #60039

tpn opened this issue Aug 31, 2012 · 5 comments
Assignees
@tpn
Labels
build The build process and cross-build

Comments

@tpn
Copy link
Member

tpn commented Aug 31, 2012

BPO 15835
Nosy @loewis, @tpn, @skrah
Files
  • issue15835.diff
    		•

    Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.

    Show more details

    GitHub fields:

    assignee = 'https://github.com/tpn'
closed_at = <Date 2012-11-12.19:40:04.089>
created_at = <Date 2012-08-31.23:52:29.381>
labels = ['build']
title = 'HP-UX build needs to be tweaked to pick up PATH_MAX'
updated_at = <Date 2012-11-12.19:40:04.088>
user = 'https://github.com/tpn'

    bugs.python.org fields:

    activity = <Date 2012-11-12.19:40:04.088>
actor = 'skrah'
assignee = 'trent'
closed = True
closed_date = <Date 2012-11-12.19:40:04.089>
closer = 'skrah'
components = []
creation = <Date 2012-08-31.23:52:29.381>
creator = 'trent'
dependencies = []
files = ['27267']
hgrepos = []
issue_num = 15835
keywords = ['patch', 'buildbot']
message_count = 5.0
messages = ['169593', '171068', '175455', '175466', '175467']
nosy_count = 4.0
nosy_names = ['loewis', 'trent', 'skrah', 'python-dev']
pr_nums = []
priority = 'normal'
resolution = 'fixed'
stage = 'resolved'
status = 'closed'
superseder = None
type = 'compile error'
url = 'https://bugs.python.org/issue15835'
versions = ['Python 2.7', 'Python 3.2', 'Python 3.3']
    @tpn
    Copy link
    Member Author

    tpn commented Aug 31, 2012

    Building on HP-UX with the HP ANSI C compiler:

    % make
    cc -Ae -c -O -O -I. -I./Include -DPy_BUILD_CORE -o Python/pythonrun.o Python/pythonrun.c
    "Python/pythonrun.c", line 805: error bpo-2020: identifier "PATH_MAX" is undefined
    static wchar_t env_home[PATH_MAX+1];
    ^

    1 error detected in the compilation of "Python/pythonrun.c".
    *** Error exit code 2

    Stop.

    Placeholder bug whilst I do some more digging.

    @tpn tpn self-assigned this Aug 31, 2012
    @tpn tpn added the build The build process and cross-build label Aug 31, 2012
    @skrah
    Copy link
    Mannequin

    skrah mannequin commented Sep 23, 2012

    PATH_MAX seems to be a mess on HP-UX: It's only defined in limits.h
    if _INCLUDE_XOPEN_SOURCE_PRE_500 is defined.

    But MAXPATHLEN is always defined in sys/param.h, so I suggest to use that
    (patch attached).

    Other projects take a similar approach by just defining PATH_MAX as 1024:

    http://lists.gnu.org/archive/html/bug-gnulib/2011-06/msg00242.html

    @loewis
    Copy link
    Mannequin

    loewis mannequin commented Nov 12, 2012

    The patch looks good, please apply.

    @python-dev
    Copy link
    Mannequin

    python-dev mannequin commented Nov 12, 2012

    New changeset 5db6d9ddf6e8 by Stefan Krah in branch '3.3':
    Issue bpo-15835: Define PATH_MAX on HP-UX.
    http://hg.python.org/cpython/rev/5db6d9ddf6e8

    @skrah
    Copy link
    Mannequin

    skrah mannequin commented Nov 12, 2012

    Thanks for reviewing!

    @skrah skrah mannequin closed this as completed Nov 12, 2012
    @ezio-melotti ezio-melotti transferred this issue from another repository Apr 10, 2022
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Assignees

    @tpn tpn

    Labels
    build The build process and cross-build
    Projects
    None yet
    Milestone
    No milestone
    Development

    No branches or pull requests
    1 participant
    @tpn