New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
asyncore and asynchat incompatible with Py3k str and bytes #45904
Comments
djarb@highenergymagic.org is working up a patch for this. |
The attached patch introduces async_chat.set_terminator_str and The patch also includes two things not materially related to its main |
Some documentation changes thanks to feedback from Giampaolo Rodola and |
There's a patch pending which should be included in the 2.6 trunk before |
Those patches can't be applied directly to the py3k branch, so instead In addition, some changes have been made to the async_chat interface: The file asyn_aggregate.diff contains the merged patches. |
Fixed a bug, and added the test that would have caught it. |
The patches that giampaolo sent you were for 2.x, not 3.x . Arguably One of my concerns with your changes (which are hard to work out because The changes that giampaolo sent you (that were from some earlier work But maybe I'm just not reading the diff correctly. |
Certainly, I'll attach the complete asyncore and asynchat files. I had a Regarding the "changes for changes sake" argument, I have two responses. First, it's perfectly reasonable to use the Dec 10th "asynchat.diff" Second, after applying Giampaolo's patch, I felt rather more free to fix Regarding the correct way to port Giampaolo's patches, I followed a |
Any progress? |
Now that the major bugs have been fixed I think this patch needs to be |
I'll update the patch and post it again. |
Thanks. I'll read it. Bill On Thu, Jul 31, 2008 at 6:16 AM, Daniel Arbuckle <report@bugs.python.org>wrote:
|
The current revision of 3.0 handles the case where reading from the From what I understand, the OP wants to be able to pass unicode strings In terms of sending (push_str), it should be an error that the user This should not be backported to any version of Python. Before discussion about actually applying any patch to |
That's incorrect. At the time I formulated this patch, asyncore/asynchat were slated for The asyn_py3k_restructured.diff patch is a superset of asyn_py3k.diff, |
Asyncore and asynchat are not going to be removed, and were not being As of right now, the tests for 3.0 pass, and when passing only bytes in If you want to change the docstrings, that's fine, submit a patch that |
As of December 2007, Guido did not believe that you or anyone else cared Thankfully there's been a resurgence of activity on the modules, and I _am_not_ proposing that passing unicode into asyncore should do On a more positive note, I'll put together that docstring patch for you |
Sounds good. I look forward to seeing the patch :) . |
Reducing priority since the critical issues seem to have been resolved |
You can probably close this unless someone says otherwise. asyncore/asynchat work in Python 3.0+, as long as only bytes are passed. |
It's not 'that' clear you should only work with bytes on a socket. |
It's pretty clear to me. :) That's what sockets can deal with - bytes. The attached patch forces the application to make this choice,
This definitely isn't reasonable and should not be done. It's also not |
On 13 jul 2009, at 17:33, Jean-Paul Calderone wrote:
It's allso clear to me, but there are people that don't know that.
It's not, I was more thinking of push_str(foo), where it uses a
It's not an attack ;), i'm pretty new to Python, and it was just |
Nice as it sounds, the problem with this is that those people cannot |
Since no doc only patch has been proposed and there is some disagreement as to whether it is needed anyway, I'm closing this per msg88559. |
Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.
Show more details
GitHub fields:
bugs.python.org fields:
The text was updated successfully, but these errors were encountered: