Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Drop TYPE_INT64 from marshal in Python 3.4 #59685

Closed
loewis mannequin opened this issue Jul 28, 2012 · 8 comments
Closed

Drop TYPE_INT64 from marshal in Python 3.4 #59685

loewis mannequin opened this issue Jul 28, 2012 · 8 comments
Labels
release-blocker type-bug An unexpected behavior, bug, or error

Comments

@loewis
Copy link
Mannequin

loewis mannequin commented Jul 28, 2012

BPO 15480
Nosy @loewis, @pitrou, @larryhastings, @ericsnowcurrently
Files
  • marshall-remove-int64.patch: Remove TYPE_INT64 from marshal.
    		•

    Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.

    Show more details

    GitHub fields:

    assignee = None
closed_at = <Date 2013-04-13.20:42:23.445>
created_at = <Date 2012-07-28.17:49:02.209>
labels = ['type-bug', 'release-blocker']
title = 'Drop TYPE_INT64 from marshal in Python 3.4'
updated_at = <Date 2013-04-13.20:44:31.079>
user = 'https://github.com/loewis'

    bugs.python.org fields:

    activity = <Date 2013-04-13.20:44:31.079>
actor = 'dan.riti'
assignee = 'none'
closed = True
closed_date = <Date 2013-04-13.20:42:23.445>
closer = 'pitrou'
components = []
creation = <Date 2012-07-28.17:49:02.209>
creator = 'loewis'
dependencies = []
files = ['29818']
hgrepos = []
issue_num = 15480
keywords = ['patch']
message_count = 8.0
messages = ['166670', '186801', '186826', '186828', '186830', '186835', '186837', '186838']
nosy_count = 6.0
nosy_names = ['loewis', 'pitrou', 'larry', 'python-dev', 'eric.snow', 'dan.riti']
pr_nums = []
priority = 'release blocker'
resolution = 'fixed'
stage = 'resolved'
status = 'closed'
superseder = None
type = 'behavior'
url = 'https://bugs.python.org/issue15480'
versions = ['Python 3.4']
    @loewis
    Copy link
    Mannequin Author

    loewis mannequin commented Jul 28, 2012

    As a follow-up of bpo-15466, TYPE_INT64 can be deleted in Python 3.4.

    @loewis loewis mannequin added the deferred-blocker label Jul 28, 2012
    @ezio-melotti ezio-melotti added release-blocker type-bug An unexpected behavior, bug, or error and removed deferred-blocker labels Nov 9, 2012
    @danriti
    Copy link
    Mannequin

    danriti mannequin commented Apr 13, 2013

    So I figured I'd give this one a shot...generated a patch to remove TYPE_INT64. Tests seem to pass, but please provide any guidance if I did something wrong! Thanks.

    @pitrou
    Copy link
    Member

    pitrou commented Apr 13, 2013

    Thank you, Daniel. The patch looks technically ok. Could you sign a contributor agreement? It will cover all your future contributions to Python: http://www.python.org/psf/contrib/

    @danriti
    Copy link
    Mannequin

    danriti mannequin commented Apr 13, 2013

    Antoine, I just filled one out maybe 2 hours ago (I'm at a CPython sprint in Boston).

    https://secure.echosign.com/public/viewAgreement?aid=T8FLXZG5LX3W2N&eid=T8GPRVI62IXF2Y&

    @pitrou
    Copy link
    Member

    pitrou commented Apr 13, 2013

    Antoine, I just filled one out maybe 2 hours ago (I'm at a CPython
    sprint in Boston).

    Ah, great, thank you!

    @python-dev
    Copy link
    Mannequin

    python-dev mannequin commented Apr 13, 2013

    New changeset 74a440984b20 by Antoine Pitrou in branch 'default':
    Issue bpo-15480: Remove the deprecated and unused TYPE_INT64 code from marshal.
    http://hg.python.org/cpython/rev/74a440984b20

    @pitrou
    Copy link
    Member

    pitrou commented Apr 13, 2013

    So, I've just tweaked the patch a bit so that ints longer than machine size are still tested for. Congrats for your first contribution!

    @pitrou pitrou closed this as completed Apr 13, 2013
    @danriti
    Copy link
    Mannequin

    danriti mannequin commented Apr 13, 2013

    Looks great, thanks Antoine! =)

    @ezio-melotti ezio-melotti transferred this issue from another repository Apr 10, 2022
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Assignees
    No one assigned
    Labels
    release-blocker type-bug An unexpected behavior, bug, or error
    Projects
    None yet
    Milestone
    No milestone
    Development

    No branches or pull requests
    2 participants
    @pitrou @ezio-melotti