Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Deprecation Warning fix on cookiejar module #59614

Closed
flavioribeiro mannequin opened this issue Jul 20, 2012 · 7 comments
Closed

Deprecation Warning fix on cookiejar module #59614

flavioribeiro mannequin opened this issue Jul 20, 2012 · 7 comments
Assignees
@meadori
Labels
stdlib Python modules in the Lib dir type-bug An unexpected behavior, bug, or error

Comments

@flavioribeiro
Copy link
Mannequin

flavioribeiro mannequin commented Jul 20, 2012

BPO 15409
Nosy @meadori
Files
  • cookiejar_fix_deprecated_method_calls.patch
  • add_flavioribeiro_acks.patch
    		•

    Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.

    Show more details

    GitHub fields:

    assignee = 'https://github.com/meadori'
closed_at = <Date 2012-07-21.00:14:51.277>
created_at = <Date 2012-07-20.17:50:17.364>
labels = ['type-bug', 'library']
title = 'Deprecation Warning fix on cookiejar module'
updated_at = <Date 2012-07-21.00:14:51.276>
user = 'https://bugs.python.org/flavioribeiro'

    bugs.python.org fields:

    activity = <Date 2012-07-21.00:14:51.276>
actor = 'meador.inge'
assignee = 'meador.inge'
closed = True
closed_date = <Date 2012-07-21.00:14:51.277>
closer = 'meador.inge'
components = ['Library (Lib)']
creation = <Date 2012-07-20.17:50:17.364>
creator = 'flavio.ribeiro'
dependencies = []
files = ['26457', '26460']
hgrepos = []
issue_num = 15409
keywords = ['patch']
message_count = 7.0
messages = ['165956', '165970', '165971', '165972', '165982', '165988', '165989']
nosy_count = 3.0
nosy_names = ['meador.inge', 'python-dev', 'flavio.ribeiro']
pr_nums = []
priority = 'normal'
resolution = 'fixed'
stage = 'resolved'
status = 'closed'
superseder = None
type = 'behavior'
url = 'https://bugs.python.org/issue15409'
versions = ['Python 3.3']
    @flavioribeiro
    Copy link
    Mannequin Author

    flavioribeiro mannequin commented Jul 20, 2012

    Cookiejar calls some urllib.Request's deprecated methods. This patch fixes this deprecated calls.

    @flavioribeiro flavioribeiro mannequin added the extension-modules C modules in the Modules dir label Jul 20, 2012
    @meadori
    Copy link
    Member

    meadori commented Jul 20, 2012

    This looks OK to me. I will commit later today.

    @meadori meadori added stdlib Python modules in the Lib dir and removed extension-modules C modules in the Modules dir labels Jul 20, 2012
    @meadori meadori self-assigned this Jul 20, 2012
    @meadori meadori added the type-bug An unexpected behavior, bug, or error label Jul 20, 2012
    @flavioribeiro
    Copy link
    Mannequin Author

    flavioribeiro mannequin commented Jul 20, 2012

    nice Meador :-)

    Already sent the form to contributors@python.org. Added also one diff to Misc/ACKS, it's up to you add it or not.

    Thanks

    @meadori
    Copy link
    Member

    meadori commented Jul 20, 2012

    I already added you to ACKS with the ctypes patch :-)

    http://hg.python.org/cpython/rev/f93efd4c45bd

    @flavioribeiro
    Copy link
    Mannequin Author

    flavioribeiro mannequin commented Jul 20, 2012

    wow :) thank you!

    @python-dev
    Copy link
    Mannequin

    python-dev mannequin commented Jul 21, 2012

    New changeset ea8078365d3b by Meador Inge in branch 'default':
    Issue bpo-15409: Replace use of deprecated urllib.request.Request methods in http.cookijar
    http://hg.python.org/cpython/rev/ea8078365d3b

    @meadori
    Copy link
    Member

    meadori commented Jul 21, 2012

    Thanks for the patch!

    @meadori meadori closed this as completed Jul 21, 2012
    @ezio-melotti ezio-melotti transferred this issue from another repository Apr 10, 2022
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Assignees

    @meadori meadori

    Labels
    stdlib Python modules in the Lib dir type-bug An unexpected behavior, bug, or error
    Projects
    None yet
    Milestone
    No milestone
    Development

    No branches or pull requests
    1 participant
    @meadori