Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

curses configure checks fail if only /usr/include/ncursesw/curses.h is installed #59473

Open
doko42 opened this issue Jul 7, 2012 · 7 comments
Labels
build The build process and cross-build

Comments

@doko42
Copy link
Member

doko42 commented Jul 7, 2012

BPO 15268
Nosy @doko42, @vstinner
Files
  • curses.diff
  • curses2.diff
  • curses3.diff
  • 4-CROSS-avoid-ncursesw-include-path-hack.patch: skip search in /usr/include/ncursesw if cross-build
  • Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.

    Show more details

    GitHub fields:

    assignee = None
    closed_at = None
    created_at = <Date 2012-07-07.01:04:27.235>
    labels = ['build']
    title = 'curses configure checks fail if only /usr/include/ncursesw/curses.h is installed'
    updated_at = <Date 2012-10-17.17:09:25.958>
    user = 'https://github.com/doko42'

    bugs.python.org fields:

    activity = <Date 2012-10-17.17:09:25.958>
    actor = 'Arfrever'
    assignee = 'none'
    closed = False
    closed_date = None
    closer = None
    components = ['Build']
    creation = <Date 2012-07-07.01:04:27.235>
    creator = 'doko'
    dependencies = []
    files = ['26276', '26277', '26278', '26567']
    hgrepos = []
    issue_num = 15268
    keywords = ['patch', 'needs review']
    message_count = 7.0
    messages = ['164765', '164766', '164767', '164769', '164771', '164780', '166732']
    nosy_count = 7.0
    nosy_names = ['doko', 'vstinner', 'rpetrov', 'Arfrever', 'devurandom', 'python-dev', 'Justin.Venus']
    pr_nums = []
    priority = 'normal'
    resolution = None
    stage = None
    status = 'open'
    superseder = None
    type = None
    url = 'https://bugs.python.org/issue15268'
    versions = ['Python 3.3']

    @doko42
    Copy link
    Member Author

    doko42 commented Jul 7, 2012

    the curses configure checks fail if only /usr/include/ncursesw/curses.h is installed (on a Debian/Ubuntu system, uninstall the libncurses5-dev package, and install the libncursesw5-dev package).

    The attached patch adds -I/usr/include/ncursesw to CPPFLAGS for the tests.

    I assume that most buildbot systems still have an /usr/include/curses.h installed, so the tests do the intended thing, because the features tested are the same in ncurses and ncursesw, but basically the wrong headers are used for these tests if both /usr/include/curses.h and /usr/include/ncursesw/curses.h are installed.

    @doko42 doko42 added the build The build process and cross-build label Jul 7, 2012
    @python-dev
    Copy link
    Mannequin

    python-dev mannequin commented Jul 7, 2012

    New changeset 707761d59a4a by doko in branch 'default':

    @doko42
    Copy link
    Member Author

    doko42 commented Jul 7, 2012

    can be closed if we don't bother to use the "wrong" header for the checks

    @doko42
    Copy link
    Member Author

    doko42 commented Jul 7, 2012

    and only add the dir for the curses.h and nurses.h header checks

    @doko42
    Copy link
    Member Author

    doko42 commented Jul 7, 2012

    and a variant, which moves all curses header related check together (curses3.diff)

    @JustinVenus
    Copy link
    Mannequin

    JustinVenus mannequin commented Jul 7, 2012

    I have a similar issue on Solaris and a patch[1] to fix it attached to bpo-3786.

    1. http://bugs.python.org/file26171/bug3786.patch

    @rpetrov
    Copy link
    Mannequin

    rpetrov mannequin commented Jul 29, 2012

    Matthias, do not use hack if cross-build

    @ezio-melotti ezio-melotti transferred this issue from another repository Apr 10, 2022
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Labels
    build The build process and cross-build
    Projects
    Status: Build
    Development

    No branches or pull requests

    1 participant