Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow equality comparison between naive and aware datetime objects #59211

Closed
abalkin opened this issue Jun 5, 2012 · 5 comments
Closed

Allow equality comparison between naive and aware datetime objects #59211

abalkin opened this issue Jun 5, 2012 · 5 comments
Assignees
Labels
extension-modules C modules in the Modules dir stdlib Python modules in the Lib dir type-feature A feature request or enhancement

Comments

@abalkin
Copy link
Member

abalkin commented Jun 5, 2012

BPO 15006
Nosy @abalkin, @pitrou, @vstinner
Files
  • issue15006.diff
  • issue15006a.diff
  • Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.

    Show more details

    GitHub fields:

    assignee = 'https://github.com/abalkin'
    closed_at = <Date 2012-06-16.00:22:21.979>
    created_at = <Date 2012-06-05.19:29:49.442>
    labels = ['extension-modules', 'type-feature', 'library']
    title = 'Allow equality comparison between naive and aware datetime objects'
    updated_at = <Date 2012-06-16.00:22:21.914>
    user = 'https://github.com/abalkin'

    bugs.python.org fields:

    activity = <Date 2012-06-16.00:22:21.914>
    actor = 'belopolsky'
    assignee = 'belopolsky'
    closed = True
    closed_date = <Date 2012-06-16.00:22:21.979>
    closer = 'belopolsky'
    components = ['Extension Modules', 'Library (Lib)']
    creation = <Date 2012-06-05.19:29:49.442>
    creator = 'belopolsky'
    dependencies = []
    files = ['25837', '26023']
    hgrepos = []
    issue_num = 15006
    keywords = []
    message_count = 5.0
    messages = ['162368', '162431', '162441', '162943', '162945']
    nosy_count = 4.0
    nosy_names = ['belopolsky', 'pitrou', 'vstinner', 'python-dev']
    pr_nums = []
    priority = 'normal'
    resolution = 'fixed'
    stage = 'resolved'
    status = 'closed'
    superseder = None
    type = 'enhancement'
    url = 'https://bugs.python.org/issue15006'
    versions = ['Python 3.3']

    @abalkin
    Copy link
    Member Author

    abalkin commented Jun 5, 2012

    Guido: Let's make it so. / python-dev

    @abalkin abalkin added extension-modules C modules in the Modules dir stdlib Python modules in the Lib dir type-feature A feature request or enhancement labels Jun 5, 2012
    @abalkin abalkin self-assigned this Jun 5, 2012
    @vstinner
    Copy link
    Member

    vstinner commented Jun 6, 2012

    Hum, can you please explain your change? If it is explained on python-dev, can you add a link to the email?

    You should documentation the behaviour change in the documentation of the datetime module.

    You chose Python 3.4, do you mean that such change is too late for Python 3.3?

    @AlexanderBelopolsky
    Copy link
    Mannequin

    AlexanderBelopolsky mannequin commented Jun 7, 2012

    On Wed, Jun 6, 2012 at 7:32 PM, STINNER Victor <report@bugs.python.org> wrote:

    Hum, can you please explain your change? If it is explained on python-dev, can you add a link to the email?

    Please see http://mail.python.org/pipermail/python-dev/2012-June/119933.html

    I don't know what to add to the title the issue. I'll see what needs
    to be done in terms of documentation and will propose a NEWS entry.

    @abalkin
    Copy link
    Member Author

    abalkin commented Jun 16, 2012

    Added documentation and simplified changes to python implementation. I think this can go to 3.3.

    @python-dev
    Copy link
    Mannequin

    python-dev mannequin commented Jun 16, 2012

    New changeset 8272699973cb by Alexander Belopolsky in branch 'default':
    Issue bpo-15006: Allow equality comparison between naive and aware time
    http://hg.python.org/cpython/rev/8272699973cb

    @abalkin abalkin closed this as completed Jun 16, 2012
    @ezio-melotti ezio-melotti transferred this issue from another repository Apr 10, 2022
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Labels
    extension-modules C modules in the Modules dir stdlib Python modules in the Lib dir type-feature A feature request or enhancement
    Projects
    None yet
    Development

    No branches or pull requests

    2 participants