Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PEP 384 Refactoring applied to _csv module #59140

Closed
RobinSchreiber mannequin opened this issue May 28, 2012 · 6 comments
Closed

PEP 384 Refactoring applied to _csv module #59140

RobinSchreiber mannequin opened this issue May 28, 2012 · 6 comments
Labels
3.10 only security fixes extension-modules C modules in the Modules dir type-feature A feature request or enhancement

Comments

@RobinSchreiber
Copy link
Mannequin

RobinSchreiber mannequin commented May 28, 2012

BPO 14935
Nosy @loewis, @encukou
PRs
  • bpo-14935: Remove static state from the _csv module #23224
    		•
    Files
  • csv_pep384.patch
  • csv_pep384_v1.patch
  • csv_pep384_v2.patch
    		•

    Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.

    Show more details

    GitHub fields:

    assignee = None
closed_at = <Date 2020-12-15.15:29:01.704>
created_at = <Date 2012-05-28.16:22:51.077>
labels = ['extension-modules', 'type-feature', '3.10']
title = 'PEP 384 Refactoring applied to _csv module'
updated_at = <Date 2020-12-15.20:00:17.362>
user = 'https://bugs.python.org/RobinSchreiber'

    bugs.python.org fields:

    activity = <Date 2020-12-15.20:00:17.362>
actor = 'terry.reedy'
assignee = 'none'
closed = True
closed_date = <Date 2020-12-15.15:29:01.704>
closer = 'petr.viktorin'
components = ['Extension Modules']
creation = <Date 2012-05-28.16:22:51.077>
creator = 'Robin.Schreiber'
dependencies = []
files = ['25745', '26381', '26797']
hgrepos = []
issue_num = 14935
keywords = ['patch']
message_count = 6.0
messages = ['161791', '161792', '165451', '168181', '383060', '383068']
nosy_count = 3.0
nosy_names = ['loewis', 'petr.viktorin', 'Robin.Schreiber']
pr_nums = ['23224']
priority = 'normal'
resolution = 'fixed'
stage = 'resolved'
status = 'closed'
superseder = None
type = 'enhancement'
url = 'https://bugs.python.org/issue14935'
versions = ['Python 3.10']
    @RobinSchreiber
    Copy link
    Mannequin Author

    RobinSchreiber mannequin commented May 28, 2012

    Corresponding to my previous Issue bpo-14732 I have now applied the Heap-Type Refactoring from PEP-341 to the _csv module. As I will apply this refactoring for almost every Standard Module, I will bundle my PEP-3121 and PEP-341 refactorings into a single patch for future releases. (In case there are no objections)

    @RobinSchreiber RobinSchreiber mannequin added extension-modules C modules in the Modules dir type-feature A feature request or enhancement labels May 28, 2012
    @RobinSchreiber
    Copy link
    Mannequin Author

    RobinSchreiber mannequin commented May 28, 2012

    I was of course referring to PEP-384. Sorry for the inconvenience.

    @RobinSchreiber RobinSchreiber mannequin changed the title PEP 341 Refactoring applied to _csv module PEP 384 Refactoring applied to _csv module May 28, 2012
    @RobinSchreiber
    Copy link
    Mannequin Author

    RobinSchreiber mannequin commented Jul 14, 2012

    Added missing INCREF and DECREF inside the dealloc, and new methods of the types.

    @RobinSchreiber
    Copy link
    Mannequin Author

    RobinSchreiber mannequin commented Aug 14, 2012

    Fixed the dealloc-methods of the types, for proper type dereferencing.

    @encukou
    Copy link
    Member

    encukou commented Dec 15, 2020

    New changeset 6a02b38 by Petr Viktorin in branch 'master':
    bpo-14935: Remove static state from the _csv module (GH-23224)
    6a02b38

    @encukou
    Copy link
    Member

    encukou commented Dec 15, 2020

    Thank you for working on this!
    It took several years and some new C-API to get it right (see PEP-630), but I believe this and the related issues bpo-18710 and bpo-34533 can now be closed.

    @encukou encukou closed this as completed Dec 15, 2020
    @terryjreedy terryjreedy added the 3.10 only security fixes label Dec 15, 2020
    @ezio-melotti ezio-melotti transferred this issue from another repository Apr 10, 2022
    @erlend-aasland erlend-aasland mentioned this issue May 7, 2023
    Merged
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Assignees
    No one assigned
    Labels
    3.10 only security fixes extension-modules C modules in the Modules dir type-feature A feature request or enhancement
    Projects
    None yet
    Milestone
    No milestone
    Development

    No branches or pull requests
    2 participants
    @encukou @terryjreedy