Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Better SSL errors #59042

Closed
pitrou opened this issue May 16, 2012 · 4 comments
Closed

Better SSL errors #59042

pitrou opened this issue May 16, 2012 · 4 comments
Labels
extension-modules C modules in the Modules dir type-feature A feature request or enhancement

Comments

@pitrou
Copy link
Member

pitrou commented May 16, 2012

BPO 14837
Nosy @birkenfeld, @pitrou
Files
  • ssl_errs.patch
    		•

    Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.

    Show more details

    GitHub fields:

    assignee = None
closed_at = <Date 2012-06-22.19:21:53.853>
created_at = <Date 2012-05-16.22:45:38.715>
labels = ['extension-modules', 'type-feature']
title = 'Better SSL errors'
updated_at = <Date 2012-06-22.19:21:53.852>
user = 'https://github.com/pitrou'

    bugs.python.org fields:

    activity = <Date 2012-06-22.19:21:53.852>
actor = 'pitrou'
assignee = 'none'
closed = True
closed_date = <Date 2012-06-22.19:21:53.853>
closer = 'pitrou'
components = ['Extension Modules']
creation = <Date 2012-05-16.22:45:38.715>
creator = 'pitrou'
dependencies = []
files = ['25621']
hgrepos = []
issue_num = 14837
keywords = ['patch']
message_count = 4.0
messages = ['160939', '163138', '163462', '163463']
nosy_count = 4.0
nosy_names = ['georg.brandl', 'exarkun', 'pitrou', 'python-dev']
pr_nums = []
priority = 'low'
resolution = 'fixed'
stage = 'resolved'
status = 'closed'
superseder = None
type = 'enhancement'
url = 'https://bugs.python.org/issue14837'
versions = ['Python 3.3']
    @pitrou
    Copy link
    Member Author

    pitrou commented May 16, 2012

    This patch tries to provide better SSL errors by using OpenSSL's official mnemonics. The sub-library mnemonic (e.g. "SSL", "PEM"...) is provided as the "library" attribute on an exception, and the reason mnemonic (e.g. "CERTIFICATE_VERIFY_FAILED") is provided as the "reason" attribute.

    I'm welcoming of any comments or suggestions.

    @pitrou pitrou added extension-modules C modules in the Modules dir type-feature A feature request or enhancement labels May 16, 2012
    @birkenfeld
    Copy link
    Member

    I'd like to see this in 3.3.

    @python-dev
    Copy link
    Mannequin

    python-dev mannequin commented Jun 22, 2012

    New changeset 96513d71e650 by Antoine Pitrou in branch 'default':
    Issue bpo-14837: SSL errors now have library and reason attributes describing precisely what happened and in which OpenSSL submodule.
    http://hg.python.org/cpython/rev/96513d71e650

    New changeset e193fe3d017e by Antoine Pitrou in branch 'default':
    Add forgotten files for bpo-14837.
    http://hg.python.org/cpython/rev/e193fe3d017e

    @pitrou
    Copy link
    Member Author

    pitrou commented Jun 22, 2012

    There it is, Georg :)
    As mentioned in the commit message, this unfortunately creates a reference leak, which is apparently related to the use of the stable ABI.

    @pitrou pitrou closed this as completed Jun 22, 2012
    @ezio-melotti ezio-melotti transferred this issue from another repository Apr 10, 2022
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Assignees
    No one assigned
    Labels
    extension-modules C modules in the Modules dir type-feature A feature request or enhancement
    Projects
    None yet
    Milestone
    No milestone
    Development

    No branches or pull requests
    2 participants
    @birkenfeld @pitrou