Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

inet_pton redefined while building with windows SDK 6.0 #45805

Closed
weck mannequin opened this issue Nov 19, 2007 · 3 comments
Closed

inet_pton redefined while building with windows SDK 6.0 #45805

weck mannequin opened this issue Nov 19, 2007 · 3 comments
Assignees
@tiran
Labels
build The build process and cross-build stdlib Python modules in the Lib dir

Comments

@weck
Copy link
Mannequin

weck mannequin commented Nov 19, 2007

BPO 1464
Nosy @tiran
Files
  • socketmodule.c.patch
    		•

    Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.

    Show more details

    GitHub fields:

    assignee = 'https://github.com/tiran'
closed_at = <Date 2007-11-21.02:32:39.565>
created_at = <Date 2007-11-19.16:32:18.118>
labels = ['build', 'library']
title = 'inet_pton redefined while building with windows SDK 6.0'
updated_at = <Date 2008-01-06.22:29:45.071>
user = 'https://bugs.python.org/weck'

    bugs.python.org fields:

    activity = <Date 2008-01-06.22:29:45.071>
actor = 'admin'
assignee = 'christian.heimes'
closed = True
closed_date = <Date 2007-11-21.02:32:39.565>
closer = 'christian.heimes'
components = ['Library (Lib)']
creation = <Date 2007-11-19.16:32:18.118>
creator = 'weck'
dependencies = []
files = ['8775']
hgrepos = []
issue_num = 1464
keywords = ['patch']
message_count = 3.0
messages = ['57639', '57653', '57723']
nosy_count = 2.0
nosy_names = ['christian.heimes', 'weck']
pr_nums = []
priority = 'normal'
resolution = 'fixed'
stage = None
status = 'closed'
superseder = None
type = 'compile error'
url = 'https://bugs.python.org/issue1464'
versions = ['Python 2.6', 'Python 3.0']
    @weck
    Copy link
    Mannequin Author

    weck mannequin commented Nov 19, 2007

    in Microsoft SDKs\Windows\v6.0A\Include\ws2tcpip.h, inet_pton was
    defined when NTDDI_VERSION >= NTDDI_LONGHORN with the following lines:

    #if (NTDDI_VERSION >= NTDDI_LONGHORN)
WINSOCK_API_LINKAGE
INT
WSAAPI
inet_pton(
    __in                                INT             Family,
    __in                                PCSTR           pszAddrString,
    __out_bcount(sizeof(IN6_ADDR))      PVOID           pAddrBuf
    );
... ...

    so in socketmodule.c, inet_pton should not be defined in such a
    situation.

    @weck weck mannequin added stdlib Python modules in the Lib dir build The build process and cross-build labels Nov 19, 2007
    @tiran
    Copy link
    Member

    tiran commented Nov 19, 2007

    I've solved the issue in the py3k differently. I've checked for
    !(defined(_MSC_VER) && _MSC_VER>1499) but your check is better. Thanks!

    @tiran tiran self-assigned this Nov 19, 2007
    @tiran
    Copy link
    Member

    tiran commented Nov 21, 2007

    Fixed in py3k and soon to be fixed in trunk when my PCbuild9 directory
    is ready.

    @tiran tiran closed this as completed Nov 21, 2007
    @ezio-melotti ezio-melotti transferred this issue from another repository Apr 10, 2022
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Assignees

    @tiran tiran

    Labels
    build The build process and cross-build stdlib Python modules in the Lib dir
    Projects
    None yet
    Milestone
    No milestone
    Development

    No branches or pull requests
    1 participant
    @tiran