Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

python3 & json: add ensure_ascii documentation #57979

Closed
socketpair mannequin opened this issue Jan 11, 2012 · 7 comments
Closed

python3 & json: add ensure_ascii documentation #57979

socketpair mannequin opened this issue Jan 11, 2012 · 7 comments
Assignees
@merwok
Labels
docs Documentation in the Doc dir type-feature A feature request or enhancement

Comments

@socketpair
Copy link
Mannequin

socketpair mannequin commented Jan 11, 2012

BPO 13770
Nosy @ezio-melotti, @merwok, @socketpair

Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.

Show more details

GitHub fields:

assignee = 'https://github.com/merwok'
closed_at = <Date 2012-02-26.02:47:39.321>
created_at = <Date 2012-01-11.16:42:10.577>
labels = ['type-feature', 'docs']
title = 'python3 & json: add ensure_ascii documentation'
updated_at = <Date 2012-02-26.02:47:39.320>
user = 'https://github.com/socketpair'

bugs.python.org fields:

activity = <Date 2012-02-26.02:47:39.320>
actor = 'eric.araujo'
assignee = 'eric.araujo'
closed = True
closed_date = <Date 2012-02-26.02:47:39.321>
closer = 'eric.araujo'
components = ['Documentation']
creation = <Date 2012-01-11.16:42:10.577>
creator = 'socketpair'
dependencies = []
files = []
hgrepos = []
issue_num = 13770
keywords = []
message_count = 7.0
messages = ['151067', '151219', '151258', '151272', '152515', '152684', '154295']
nosy_count = 5.0
nosy_names = ['ezio.melotti', 'eric.araujo', 'docs@python', 'socketpair', 'python-dev']
pr_nums = []
priority = 'normal'
resolution = 'fixed'
stage = 'resolved'
status = 'closed'
superseder = None
type = 'enhancement'
url = 'https://bugs.python.org/issue13770'
versions = ['Python 3.2', 'Python 3.3']
@socketpair
Copy link
Mannequin Author

socketpair mannequin commented Jan 11, 2012

Please fix documentation about ensure_ascii. Does it have any meaning in python3?

@socketpair socketpair mannequin assigned docspython Jan 11, 2012
@socketpair socketpair mannequin added docs Documentation in the Doc dir type-feature A feature request or enhancement labels Jan 11, 2012
@merwok
Copy link
Member

merwok commented Jan 14, 2012

Most probably. The text model of Python has no bearing on the JSON spec, and 2.x as well as 3.x Pythons may want to output UTF-8 JSON or JavaScript-escaped ASCII-only JSON. What specific wording is an issue?

@socketpair
Copy link
Mannequin Author

socketpair mannequin commented Jan 14, 2012

ensure_ascii is documented only in Jsonencoder class. Other functions like dumps() should refer to this class description for that parameter.

@merwok
Copy link
Member

merwok commented Jan 15, 2012

All right. I’ll do like other parameters (see check_circular for an example) and just duplicate the two-line doc.

@merwok merwok assigned merwok and unassigned docspython Jan 15, 2012
@merwok
Copy link
Member

merwok commented Feb 3, 2012

FTR I’ve fixed this and now need to find a place with SSH access so I can push.

@python-dev
Copy link
Mannequin

python-dev mannequin commented Feb 5, 2012

New changeset 33d6da1b1c71 by Éric Araujo in branch '3.2':
Document json.dump ensure_ascii parameter (bpo-13770)
http://hg.python.org/cpython/rev/33d6da1b1c71

New changeset 1cb9b8126534 by Éric Araujo in branch 'default':
Merge edits from 3.2 (bpo-13716, bpo-1040439, bpo-2945, bpo-13770, bpo-6715)
http://hg.python.org/cpython/rev/1cb9b8126534

@merwok
Copy link
Member

merwok commented Feb 26, 2012

json in 2.7 works a bit differently; ensure_ascii is already documented there. Closing, please reopen if the new doc is not to your satisfaction.

@merwok merwok closed this as completed Feb 26, 2012
@ezio-melotti ezio-melotti transferred this issue from another repository Apr 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@merwok merwok

Labels
docs Documentation in the Doc dir type-feature A feature request or enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@merwok