Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Python SSL stack doesn't support Compression configuration #57843

Closed
naif mannequin opened this issue Dec 19, 2011 · 6 comments
Closed

Python SSL stack doesn't support Compression configuration #57843

naif mannequin opened this issue Dec 19, 2011 · 6 comments
Labels
stdlib Python modules in the Lib dir type-feature A feature request or enhancement

Comments

@naif
Copy link
Mannequin

naif mannequin commented Dec 19, 2011

BPO 13634
Nosy @jcea, @pitrou
Files
  • compression.patch
    		•

    Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.

    Show more details

    GitHub fields:

    assignee = None
closed_at = <Date 2011-12-20.09:19:08.287>
created_at = <Date 2011-12-19.10:39:58.577>
labels = ['type-feature', 'library']
title = "Python SSL stack doesn't support Compression configuration"
updated_at = <Date 2011-12-20.09:19:08.286>
user = 'https://bugs.python.org/naif'

    bugs.python.org fields:

    activity = <Date 2011-12-20.09:19:08.286>
actor = 'pitrou'
assignee = 'none'
closed = True
closed_date = <Date 2011-12-20.09:19:08.287>
closer = 'pitrou'
components = ['Library (Lib)']
creation = <Date 2011-12-19.10:39:58.577>
creator = 'naif'
dependencies = []
files = ['24052']
hgrepos = []
issue_num = 13634
keywords = ['patch']
message_count = 6.0
messages = ['149830', '149838', '149864', '149865', '149906', '149907']
nosy_count = 4.0
nosy_names = ['jcea', 'pitrou', 'python-dev', 'naif']
pr_nums = []
priority = 'normal'
resolution = 'fixed'
stage = 'resolved'
status = 'closed'
superseder = None
type = 'enhancement'
url = 'https://bugs.python.org/issue13634'
versions = ['Python 3.3']
    @naif
    Copy link
    Mannequin Author

    naif mannequin commented Dec 19, 2011

    TLSv1 support compression with gzip/deflate that can provide for a lot of protocols a great improvement (just think about SIP/TLS or IMAP) in terms of bandwidth.

    Currenly Python SSL stack based on OpenSSL doesn't allow the configuration (enabling/disabling/forcing) of TLS compression.

    This ticket is about suggesting to implement TLS compression configuration of OpenSSL as described on:
    http://blog.dave.cridland.net/?p=73

    @naif naif mannequin added the stdlib Python modules in the Lib dir label Dec 19, 2011
    @pitrou
    Copy link
    Member

    pitrou commented Dec 19, 2011

    So, there are two things here:

    • allow to disable compression (it's enabled by default AFAICT) using the SSL_OP_NO_COMPRESSION flag
    • allow to query compression status on SSL sockets using the SSL_get_current_compression() API

    @pitrou pitrou added the type-feature A feature request or enhancement label Dec 19, 2011
    @pitrou
    Copy link
    Member

    pitrou commented Dec 19, 2011

    Here is a patch.

    @pitrou
    Copy link
    Member

    pitrou commented Dec 19, 2011

    (note that some OpenSSLs are built without compression, such as Mageia's)

    @python-dev
    Copy link
    Mannequin

    python-dev mannequin commented Dec 20, 2011

    New changeset 20b52be99b5d by Antoine Pitrou in branch 'default':
    Issue bpo-13634: Add support for querying and disabling SSL compression.
    http://hg.python.org/cpython/rev/20b52be99b5d

    @pitrou
    Copy link
    Member

    pitrou commented Dec 20, 2011

    Now committed in 3.3.

    @pitrou pitrou closed this as completed Dec 20, 2011
    @ezio-melotti ezio-melotti transferred this issue from another repository Apr 10, 2022
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Assignees
    No one assigned
    Labels
    stdlib Python modules in the Lib dir type-feature A feature request or enhancement
    Projects
    None yet
    Milestone
    No milestone
    Development

    No branches or pull requests
    1 participant
    @pitrou