Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

correction for test_fileinput in py3k on Windows #45682

Closed
amauryfa opened this issue Oct 26, 2007 · 2 comments
Closed

correction for test_fileinput in py3k on Windows #45682

amauryfa opened this issue Oct 26, 2007 · 2 comments
Labels
OS-windows

Comments

@amauryfa
Copy link
Member

BPO 1341
Nosy @gvanrossum, @amauryfa
Files
  • fileinput.diff
    		•

    Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.

    Show more details

    GitHub fields:

    assignee = None
closed_at = <Date 2007-10-29.17:40:14.950>
created_at = <Date 2007-10-26.23:59:30.345>
labels = ['OS-windows']
title = 'correction for test_fileinput in py3k on Windows'
updated_at = <Date 2007-10-29.17:40:14.948>
user = 'https://github.com/amauryfa'

    bugs.python.org fields:

    activity = <Date 2007-10-29.17:40:14.948>
actor = 'gvanrossum'
assignee = 'none'
closed = True
closed_date = <Date 2007-10-29.17:40:14.950>
closer = 'gvanrossum'
components = ['Windows']
creation = <Date 2007-10-26.23:59:30.345>
creator = 'amaury.forgeotdarc'
dependencies = []
files = ['8623']
hgrepos = []
issue_num = 1341
keywords = ['patch']
message_count = 2.0
messages = ['56833', '56915']
nosy_count = 2.0
nosy_names = ['gvanrossum', 'amaury.forgeotdarc']
pr_nums = []
priority = 'normal'
resolution = 'accepted'
stage = None
status = 'closed'
superseder = None
type = None
url = 'https://bugs.python.org/issue1341'
versions = ['Python 3.0']
    @amauryfa
    Copy link
    Member Author

    This patch corrects test_fileinput on Windows: when redirecting stdout,
    os.open should be given O_BINARY, because the file descriptor is then
    wrapped in a text-mode file; os.fdopen(fd, "w").

    @gvanrossum
    Copy link
    Member

    Thanks, good catch!

    Committed revision 58704.

    (in the py3k branch)

    @ezio-melotti ezio-melotti transferred this issue from another repository Apr 10, 2022
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Assignees
    No one assigned
    Labels
    OS-windows
    Projects
    None yet
    Milestone
    No milestone
    Development

    No branches or pull requests
    2 participants
    @amauryfa @gvanrossum