New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Figure out extended attributes on BSDs #57187
Comments
Extended attribute support currently exists in the os module for Linux. BSD's (including OSX) have a similar (but of course incompatible) interface. They should be exposed through the same functions. For example, os.getxattr("myfile", "user.whatever") should call on the C level getxattr("myfile", "user.whatever", value, sizeof(value), 0, 0); |
Have you looked at Bob Ippolito's xattr module which has been out for some time and wraps Linux, OS X, BSD, and Solaris extended attributes? |
I've spent a few hours looking at xattr and the Linux/OS X (10.4+) implementations. Bob Ippolito's xattr module implements the OS X xattr interface on Linux, Solaris (9+) and FreeBSD. Linux and OS X are pretty close; FreeBSD and Solaris are substantially different from either and the Solaris implementation is somewhat incomplete/broken. The OS X differences from Linux are: • Instead of l* functions, the XATTR_NOFOLLOW option • XATTR_NOSECURITY and XATTR_NODEFAULT are in the headers but essentially unavailable as the kernel code always returns EINVAL for them. • XATTR_SHOWCOMPRESSION to expose the HFS compression stuff, which I can't imagine many people needing • XATTR_MAXNAMELEN (but no equivalent to XATTR_SIZE_MAX). Linux has a corresponding XATTR_NAME_MAX, which we should probably expose too. • XATTR_FINDERINFO_NAME and XATTR_RESOURCEFORK_NAME for some standard attribute names. I would imagine these are worth exposing. I don't see any problems supporting the currently exposed Linux API on OS X (I could probably find a usable value for XATTR_SIZE_MAX), but it's unclear if that is the right way to go forward. Suggestions? |
2012/3/12 Nicholas Riley <report@bugs.python.org>:
Thanks for looking into this. I think the best approach at the moment |
FreeBSD (at least on 7.x, 8.x and 9.x) has the following syscalls available in its API: extattr_{get,set,list,delete}_{fd,file,link} And also has: EXTATTR_MAXNAMELEN http://www.freebsd.org/cgi/man.cgi?query=extattr&sektion=2&manpath=FreeBSD+9.0-RELEASE |
And to clarify the no-follow-symlinks case on FreeBSD: extattr_{get,set,list,delete}_link "system calls behave in the same way as their _file counterparts, except that they do not follow sym-links." as per the man page. |
The OSX API also has a "position" argument for both getting and setting extended attributes. The position should be 0 for normal attributes, and can have other values when accessing the resource fork of a file. |
Here's an initial attempt at implementing extended attribute support. Let me know if there's any interest. There's currently one deficiency, which is that the namespace isn't prepended to the attribute name when calling lsxattr. Let me know if my approach is good, so I can continue fixing lsxattr. All other unit tests pass. |
Is there any chance of getting this finalized? I have been using William Orr's patch as a workaround for months now, but it would be nice to not have to manually apply it each version bump... |
There certainly is interest in supporting extended attributes on additional platforms. Thanks for the patch, William, and the positive comments, Billy. Since this probably falls into the category of new feature, it should be targeted for 3.6, now that 3.5 is in feature-freeze and nearing release. The gating factor is getting a core developer to review and champion it. |
After a considerable amount of rework, I've gotten something worth submitting. All unit tests pass, and it handles some of the more unfortunate differences between FreeBSD's extended attribute syscalls and Linux's. One of the bigger changes is that I reworked the calls to getxattr and listxattr. These used to be called with a small buffer, and if the size of the extended attribute(s) exceeded the buffer length, we'd throw out that buffer and start again with a buffer of the maximum possible attribute size allocated. I threw this out, and opted for always making two calls - one to get the size of the buffer, and one to actually get the contents (or list of attributes). This works the same for both FreeBSD and Linux. FreeBSD's extattr_get_* and extattr_list_* unfortunately only return the number of bytes read, *not* the number of bytes in the attribute value or the list. That means that there's no real way to determine if we've read less data than there is in the attribute. This passes the unit tests (on FreeBSD 10.1). I'd be interested to see results from other users and comments. |
I wanted to pick this up, and port the PR to current Python and add support for macOS. There are some platform differences, and I need help deciding how to proceed. Some of these were discussed above, but let me summarize.
I will prepare an updated PR. Meanwhile, I appreciate any input on these points. Footnotes
|
Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.
Show more details
GitHub fields:
bugs.python.org fields:
Linked PRs
The text was updated successfully, but these errors were encountered: