Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

libffi needs an update to support mips64, arm and armeabi on linux #45633

Closed
doko42 opened this issue Oct 18, 2007 · 11 comments
Closed

libffi needs an update to support mips64, arm and armeabi on linux #45633

doko42 opened this issue Oct 18, 2007 · 11 comments
Assignees
@theller
Labels
build The build process and cross-build extension-modules C modules in the Modules dir

Comments

@doko42
Copy link
Member

doko42 commented Oct 18, 2007

BPO 1292
Nosy @theller, @doko42
Files
  • arm.diff
    		•

    Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.

    Show more details

    GitHub fields:

    assignee = 'https://github.com/theller'
closed_at = <Date 2008-03-05.14:58:26.478>
created_at = <Date 2007-10-18.09:23:06.461>
labels = ['extension-modules', 'build']
title = 'libffi needs an update to support mips64, arm and armeabi on linux'
updated_at = <Date 2008-03-05.14:58:26.477>
user = 'https://github.com/doko42'

    bugs.python.org fields:

    activity = <Date 2008-03-05.14:58:26.477>
actor = 'theller'
assignee = 'theller'
closed = True
closed_date = <Date 2008-03-05.14:58:26.478>
closer = 'theller'
components = ['Extension Modules']
creation = <Date 2007-10-18.09:23:06.461>
creator = 'doko'
dependencies = []
files = ['8605']
hgrepos = []
issue_num = 1292
keywords = []
message_count = 11.0
messages = ['56522', '56726', '56753', '57000', '57001', '57005', '57063', '60005', '62139', '62638', '63280']
nosy_count = 2.0
nosy_names = ['theller', 'doko']
pr_nums = []
priority = 'normal'
resolution = 'fixed'
stage = None
status = 'closed'
superseder = None
type = 'compile error'
url = 'https://bugs.python.org/issue1292'
versions = ['Python 2.6']
    @doko42
    Copy link
    Member Author

    doko42 commented Oct 18, 2007

    libffi needs an update to support mips64, arm and armeabi on linux; the
    current bits are all available in GCC trunk. as an alternative, those
    systems should be default to --with-system-ffi, unless this is
    xplicitely disabled.

    @doko42 doko42 added extension-modules C modules in the Modules dir build The build process and cross-build labels Oct 18, 2007
    @doko42
    Copy link
    Member Author

    doko42 commented Oct 24, 2007

    committed the following patch to the trunk (lets the buildds test the
    ctypes extension)

    @theller
    Copy link

    theller commented Oct 25, 2007

    I'm unsure how to proceed with this.
    Replacing the copy of libffi in the ctypes sources - I'm very afraid to
    do that. It has it's own configure system, written by someone else.
    Then it has several changes from various people for Python, which would
    be overwritten. All these on systems that I do not have direct access
    to, and we do not have buildbots for all of them.

    So, it looks like --with-system-ffi should be made the default (on
    systems that have libffi installed?)

    There are also test failures since I committed the c_longdouble patch
    (on alpha debian, and S390 Debian, for example). Maybe newer libffi
    versions have a fix for that...

    Last comment: Experimental changes COULD be tested out in a branch, we
    would only have to manually trigger the build from the buildbot web pages.

    @theller
    Copy link

    theller commented Oct 31, 2007

    In the branches_ctypes-branch I hacked setup.py to always use an
    installed libffi if one is found. Then I triggered the trunk buildbots
    which failed or crashed before in some c_longdouble tests; the tests
    worked ok on them (ppc Debian unstable, and S-390 Debian).

    @theller
    Copy link

    theller commented Oct 31, 2007

    I meant branches/ctypes_branch, of course.

    @doko42
    Copy link
    Member Author

    doko42 commented Oct 31, 2007

    oops, did the same for arm* on trunk, but in configure.in

    @theller
    Copy link

    theller commented Nov 2, 2007

    I have now made --with-system-ffi default to "yes" for Linux/alpha*,
    Linux/arm*, Linux/ppc*, and Linux/s390* machines. If you think it is
    needed for mips machines also please add this - there's no buildbot
    where I can check the result.

    @theller
    Copy link

    theller commented Jan 16, 2008

    Matthias, can this issue be set to 'fixed' and 'closed' now?

    @doko42
    Copy link
    Member Author

    doko42 commented Feb 7, 2008

    there's a buildbot for mips-linux, none for mips64, so lets close this one.

    @doko42 doko42 closed this as completed Feb 7, 2008
    @theller
    Copy link

    theller commented Feb 21, 2008

    I'm reopening this. libffi 3 has been released; I have created the
    libffi3-branch for this work in Python svn.

    @theller theller reopened this Feb 21, 2008
    @theller
    Copy link

    theller commented Mar 5, 2008

    libffi3-branch has been merged to trunk; the Modules/_ctypes/libffi
    files are from the libffi 3.0.4 release now.

    @theller theller closed this as completed Mar 5, 2008
    @ezio-melotti ezio-melotti transferred this issue from another repository Apr 10, 2022
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Assignees

    @theller theller

    Labels
    build The build process and cross-build extension-modules C modules in the Modules dir
    Projects
    None yet
    Milestone
    No milestone
    Development

    No branches or pull requests
    2 participants
    @theller @doko42