Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test_urllib2net is triggering a ResourceWarning #56901

Closed
brettcannon opened this issue Aug 5, 2011 · 7 comments
Closed

test_urllib2net is triggering a ResourceWarning #56901

brettcannon opened this issue Aug 5, 2011 · 7 comments
Assignees
@orsenthil
Labels
performance Performance or resource usage tests Tests in the Lib/test dir

Comments

@brettcannon
Copy link
Member

BPO 12692
Nosy @brettcannon, @orsenthil, @vadmium

Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.

Show more details

GitHub fields:

assignee = 'https://github.com/orsenthil'
closed_at = <Date 2012-10-21.15:45:23.457>
created_at = <Date 2011-08-05.05:02:31.361>
labels = ['tests', 'performance']
title = 'test_urllib2net is triggering a ResourceWarning'
updated_at = <Date 2013-12-29.01:38:25.307>
user = 'https://github.com/brettcannon'

bugs.python.org fields:

activity = <Date 2013-12-29.01:38:25.307>
actor = 'orsenthil'
assignee = 'orsenthil'
closed = True
closed_date = <Date 2012-10-21.15:45:23.457>
closer = 'nadeem.vawda'
components = ['Tests']
creation = <Date 2011-08-05.05:02:31.361>
creator = 'brett.cannon'
dependencies = []
files = []
hgrepos = []
issue_num = 12692
keywords = []
message_count = 7.0
messages = ['141645', '141649', '141673', '173459', '207055', '207060', '207061']
nosy_count = 5.0
nosy_names = ['brett.cannon', 'orsenthil', 'nadeem.vawda', 'python-dev', 'martin.panter']
pr_nums = []
priority = 'low'
resolution = 'fixed'
stage = 'resolved'
status = 'closed'
superseder = None
type = 'resource usage'
url = 'https://bugs.python.org/issue12692'
versions = ['Python 3.2', 'Python 3.3']
@brettcannon
Copy link
Member Author

Specifically, test.test_urllib2net.OtherNetworkTests.test_sites_no_connection_close is leaving a socket open somewhere, but tracking down exactly whom is to blame is a mess since socket.SocketIO.close() explicitly relies on refcounting to shut down a socket.

@brettcannon brettcannon added tests Tests in the Lib/test dir performance Performance or resource usage labels Aug 5, 2011
@nadeemvawda
Copy link
Mannequin

nadeemvawda mannequin commented Aug 5, 2011

Relevant: http://mail.python.org/pipermail/python-dev/2011-July/112551.html

@brettcannon
Copy link
Member Author

Thanks for the info, Nadeem.

@python-dev
Copy link
Mannequin

python-dev mannequin commented Oct 21, 2012

New changeset 92656b5df2f2 by Nadeem Vawda in branch 'default':
Issue bpo-12692: Fix resource leak in urllib.request.
http://hg.python.org/cpython/rev/92656b5df2f2

@nadeemvawda nadeemvawda mannequin closed this as completed Oct 21, 2012
@vadmium
Copy link
Member

vadmium commented Dec 28, 2013

Any chance of backporting this to version 3.3? I think it is a real-world issue beyond the test suite. See bpo-19524.

@python-dev
Copy link
Mannequin

python-dev mannequin commented Dec 29, 2013

New changeset a43e96695203 by Senthil Kumaran in branch '3.3':
Backporing the fix from Issue bpo-12692
http://hg.python.org/cpython/rev/a43e96695203

New changeset 031417ee8351 by Senthil Kumaran in branch 'default':
bpo-12692: null merge with 3.3
http://hg.python.org/cpython/rev/031417ee8351

@orsenthil
Copy link
Member

@martin. Agree that this should have been backported. I have done that.
Thank you!

@ezio-melotti ezio-melotti transferred this issue from another repository Apr 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@orsenthil orsenthil

Labels
performance Performance or resource usage tests Tests in the Lib/test dir
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@brettcannon @orsenthil @vadmium