Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Check status returns in msilib.SummaryInformation.GetProperty() #56411

Closed
markm mannequin opened this issue May 28, 2011 · 5 comments
Closed

Check status returns in msilib.SummaryInformation.GetProperty() #56411

markm mannequin opened this issue May 28, 2011 · 5 comments
Labels
3.8 only security fixes OS-windows type-bug An unexpected behavior, bug, or error

Comments

@markm
Copy link
Mannequin

markm mannequin commented May 28, 2011

BPO 12202
Nosy @loewis, @tjguk, @berkerpeksag, @zware, @zooba, @ZackerySpytz
PRs
  • bpo-12202: Properly check MsiSummaryInfoGetProperty() calls in msilib #13711
  • [3.7] bpo-12202: Properly check MsiSummaryInfoGetProperty() calls in msilib (GH-13711) #13712
    		•
    Files
  • ensure_MsiSummaryInfoGetProperty_return_value_checked.patch: patch to check return value (and some tests)
    		•

    Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.

    Show more details

    GitHub fields:

    assignee = None
closed_at = <Date 2019-06-01.00:16:49.568>
created_at = <Date 2011-05-28.13:59:35.736>
labels = ['type-bug', '3.8', 'OS-windows']
title = 'Check status returns in msilib.SummaryInformation.GetProperty()'
updated_at = <Date 2019-06-01.01:11:26.617>
user = 'https://bugs.python.org/markm'

    bugs.python.org fields:

    activity = <Date 2019-06-01.01:11:26.617>
actor = 'ZackerySpytz'
assignee = 'none'
closed = True
closed_date = <Date 2019-06-01.00:16:49.568>
closer = 'berker.peksag'
components = ['Windows']
creation = <Date 2011-05-28.13:59:35.736>
creator = 'markm'
dependencies = []
files = ['22165']
hgrepos = []
issue_num = 12202
keywords = ['patch']
message_count = 5.0
messages = ['137132', '137134', '242647', '344132', '344140']
nosy_count = 7.0
nosy_names = ['loewis', 'tim.golden', 'markm', 'berker.peksag', 'zach.ware', 'steve.dower', 'ZackerySpytz']
pr_nums = ['13711', '13712']
priority = 'normal'
resolution = 'fixed'
stage = 'resolved'
status = 'closed'
superseder = None
type = 'behavior'
url = 'https://bugs.python.org/issue12202'
versions = ['Python 3.8']
    @markm
    Copy link
    Mannequin Author

    markm mannequin commented May 28, 2011

    Per Eric V. Smith's comment bpo-1104 (msg134976) the return value of the call MsiSummaryInfoGetProperty() in summary_getproperty() (pc\_msi.c) is only checked for the error return ERROR_MORE_DATA.

    Other error values should be checked.

    @markm
    Copy link
    Mannequin Author

    markm mannequin commented May 28, 2011

    I have added tests to the patch - but it's not easy to know what would cause an error in MsiSummaryInfoGetProperty which would trigger the new code.

    @BreamoreBoy
    Copy link
    Mannequin

    BreamoreBoy mannequin commented May 6, 2015

    The code change to _msi.c is minimal, the bulk of the patch is additional test code. I think we could still use this. Thoughts?

    See also bpo-1104.

    @BreamoreBoy BreamoreBoy mannequin added the OS-windows label May 6, 2015
    @ZackerySpytz
    Copy link
    Mannequin

    ZackerySpytz mannequin commented May 31, 2019

    This issue needs to be fixed. Passing an invalid value to SummaryInformation.GetProperty() will cause the first MsiSummaryInfoGetProperty() call to fail. As the call is not properly checked, the "type" variable will then be used uninitialized in summary_getproperty().

    @ZackerySpytz ZackerySpytz mannequin added 3.7 (EOL) end of life 3.8 only security fixes type-bug An unexpected behavior, bug, or error labels May 31, 2019
    @berkerpeksag
    Copy link
    Member

    New changeset 549e55a by Berker Peksag (Zackery Spytz) in branch 'master':
    bpo-12202: Properly check MsiSummaryInfoGetProperty() calls in msilib (GH-13711)
    549e55a

    @berkerpeksag berkerpeksag removed the 3.7 (EOL) end of life label Jun 1, 2019
    @ezio-melotti ezio-melotti transferred this issue from another repository Apr 10, 2022
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Assignees
    No one assigned
    Labels
    3.8 only security fixes OS-windows type-bug An unexpected behavior, bug, or error
    Projects
    None yet
    Milestone
    No milestone
    Development

    No branches or pull requests
    1 participant
    @berkerpeksag