Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

new patch for fixing skipitem() in getargs.c #42044

Closed
birkenfeld opened this issue Jun 1, 2005 · 2 comments
Closed

new patch for fixing skipitem() in getargs.c #42044

birkenfeld opened this issue Jun 1, 2005 · 2 comments
Assignees
@birkenfeld
Labels
interpreter-core (Objects, Python, Grammar, and Parser dirs)

Comments

@birkenfeld
Copy link
Member

BPO 1212928
Nosy @birkenfeld, @birkenfeld
Files
  • getargs-skipitem-diff: Diff to complete switch stmt
  • new-skipitem.c: whole new skipitem() impl
    		•

    Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.

    Show more details

    GitHub fields:

    assignee = 'https://github.com/birkenfeld'
closed_at = <Date 2005-09-14.19:32:05.000>
created_at = <Date 2005-06-01.18:21:54.000>
labels = ['interpreter-core']
title = 'new patch for fixing skipitem() in getargs.c'
updated_at = <Date 2005-09-14.19:32:05.000>
user = 'https://github.com/birkenfeld'

    bugs.python.org fields:

    activity = <Date 2005-09-14.19:32:05.000>
actor = 'georg.brandl'
assignee = 'georg.brandl'
closed = True
closed_date = None
closer = None
components = ['Interpreter Core']
creation = <Date 2005-06-01.18:21:54.000>
creator = 'georg.brandl'
dependencies = []
files = ['6677', '6678']
hgrepos = []
issue_num = 1212928
keywords = ['patch']
message_count = 2.0
messages = ['48417', '48418']
nosy_count = 2.0
nosy_names = ['georg.brandl', 'georg.brandl']
pr_nums = []
priority = 'normal'
resolution = 'accepted'
stage = None
status = 'closed'
superseder = None
type = None
url = 'https://bugs.python.org/issue1212928'
versions = ['Python 2.4']
    @birkenfeld
    Copy link
    Member Author

    This patch subsumes bpo-985713 and bpo-853890.

    In Python/getargs.c, the function skipitem() has not
    been updated with new argument format codes, such as u,
    u#, w, w# etc. This is corrected with this patch.

    There are two possibilities: either all new codes are
    added to the switch statement (this is the file
    getargs-skipitem-diff), or the function is rewritten so
    that there is no need for a switch (because the pointer
    type for va_arg is irrelevant). That solution is in the
    file new_skipitem.c.

    Remaining issue: I don't know if the '(...)' formatting
    code should be handled here.

    @birkenfeld birkenfeld self-assigned this Jun 1, 2005
    @birkenfeld birkenfeld added the interpreter-core (Objects, Python, Grammar, and Parser dirs) label Jun 1, 2005
    @birkenfeld birkenfeld self-assigned this Jun 1, 2005
    @birkenfeld birkenfeld added the interpreter-core (Objects, Python, Grammar, and Parser dirs) label Jun 1, 2005
    @birkenfeld
    Copy link
    Member Author

    Logged In: YES
    user_id=1188172

    I used a hybrid solution now. The checking for invalid
    characters remains, but the type argument is irrelevant.

    Python/getargs.c r2.107 and r2.102.2.4.

    @ezio-melotti ezio-melotti transferred this issue from another repository Apr 9, 2022
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Assignees

    @birkenfeld birkenfeld

    Labels
    interpreter-core (Objects, Python, Grammar, and Parser dirs)
    Projects
    None yet
    Milestone
    No milestone
    Development

    No branches or pull requests
    1 participant
    @birkenfeld