New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
regrtest.py doesn't check for unexpected output anymore? #56298
Comments
In Python 3.1, a test fails if it writes to stdout/stderr. It is no more the case in Python 3.2 and 3.3. Why? If we decided to not check for unexpected output in Python 3.2+, the following code should be removed: if verbose:
capture_stdout = None
else:
capture_stdout = io.StringIO() |
Antoine removed that check as part of the -j support, if I recall correctly. The check for unexpected output was part of the support for the transition between the old pre-unittest test suite and the unittest based test suite, and does seem like it is obsolete. Presumably we will visually spot unexpected output during pre-checkin testing. |
@antoine: What's your opinion? |
IMO this was all obsolete long ago, when we replaced stdout-based comparison of test results with proper assert* method calls. |
New changeset 6051f2c93163 by Victor Stinner in branch 'default': |
Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.
Show more details
GitHub fields:
bugs.python.org fields:
The text was updated successfully, but these errors were encountered: