Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

expat binding for XML_ParserReset #42014

Closed
eikenberry mannequin opened this issue May 25, 2005 · 9 comments
Closed

expat binding for XML_ParserReset #42014

eikenberry mannequin opened this issue May 25, 2005 · 9 comments
Labels
extension-modules C modules in the Modules dir pending The issue will be closed if no feedback is provided topic-XML type-feature A feature request or enhancement

Comments

@eikenberry
Copy link
Mannequin

eikenberry mannequin commented May 25, 2005

BPO 1208730
Nosy @loewis, @amauryfa, @tiran
Files
  • pyexpat.patch: Patch adding XML_ParserReset binding
    		•

    Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.

    Show more details

    GitHub fields:

    assignee = None
closed_at = None
created_at = <Date 2005-05-25.20:37:55.000>
labels = ['extension-modules', 'expert-XML', 'type-feature']
title = 'expat binding for XML_ParserReset'
updated_at = <Date 2014-02-03.15:45:30.466>
user = 'https://bugs.python.org/eikenberry'

    bugs.python.org fields:

    activity = <Date 2014-02-03.15:45:30.466>
actor = 'BreamoreBoy'
assignee = 'none'
closed = False
closed_date = None
closer = None
components = ['Extension Modules', 'XML']
creation = <Date 2005-05-25.20:37:55.000>
creator = 'eikenberry'
dependencies = []
files = ['8253']
hgrepos = []
issue_num = 1208730
keywords = ['patch']
message_count = 8.0
messages = ['54535', '54536', '54537', '54538', '54539', '54540', '93786', '114994']
nosy_count = 6.0
nosy_names = ['loewis', 'nnorwitz', 'amaury.forgeotdarc', 'zseil', 'eikenberry', 'christian.heimes']
pr_nums = []
priority = 'normal'
resolution = None
stage = 'patch review'
status = 'open'
superseder = None
type = 'enhancement'
url = 'https://bugs.python.org/issue1208730'
versions = ['Python 3.5']
    @eikenberry
    Copy link
    Mannequin Author

    eikenberry mannequin commented May 25, 2005

    XML_ParserReset is an expat parser method for resetting the parser to handle a new document.

    This keeps you from having to create a new parser for each document.

    @eikenberry eikenberry mannequin added extension-modules C modules in the Modules dir type-feature A feature request or enhancement labels May 25, 2005
    @loewis
    Copy link
    Mannequin

    loewis mannequin commented May 30, 2005

    Logged In: YES
    user_id=21627

    Would you like to work on a patch for this feature? Exposing
    more methods from Expat is a good idea.

    @eikenberry
    Copy link
    Mannequin Author

    eikenberry mannequin commented May 31, 2005

    Logged In: YES
    user_id=322022

    Ok. I gave it a whirl. The patch is attached. If you have a moment, could you please look over it and let me know if I made any mistakes. Its a forward diff as recommended by the guidelines. I tried to follow them as much as possible.

    Thanks.

    @eikenberry
    Copy link
    Mannequin Author

    eikenberry mannequin commented May 31, 2005

    Logged In: YES
    user_id=322022

    Forgot to mention I made the patch against current CVS.

    @nnorwitz
    Copy link
    Mannequin

    nnorwitz mannequin commented Oct 1, 2005

    Logged In: YES
    user_id=33168

    See patch bpo-1208730.

    @zseil
    Copy link
    Mannequin

    zseil mannequin commented Apr 7, 2006

    Logged In: YES
    user_id=1326842

    That is patch bpo-1244208.

    @devdanzin devdanzin mannequin added topic-XML labels Mar 30, 2009
    @amauryfa
    Copy link
    Member

    amauryfa commented Oct 9, 2009

    This (old) patch needs some work:

    • unit tests are neeeded.

    • it it not enough to return NULL when XML_ParserReset() returns an
      error; a python exception must be raised.

    • "This function may not be used on a parser created using
      XML_ExternalEntityParserCreate": if XML_ParserReset() does not check it
      properly, we should ensure that an exception is properly raised.

    • "How many of the struct elements do I need to reset?": this should be
      worked out. And I'm not convinced that self->intern should be reset.

    @BreamoreBoy
    Copy link
    Mannequin

    BreamoreBoy mannequin commented Aug 26, 2010

    Anyone interested in updating the patch for 3.2?

    @tiran tiran unassigned tiran Nov 20, 2013
    @ezio-melotti ezio-melotti transferred this issue from another repository Apr 9, 2022
    @iritkatriel
    Copy link
    Member

    This has been abandoned for over a decade. Marking as pending and will close soon if nobody will object.

    @iritkatriel iritkatriel added the pending The issue will be closed if no feedback is provided label Apr 24, 2023
    @iritkatriel iritkatriel closed this as not planned Won't fix, can't repro, duplicate, stale May 9, 2023
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Assignees
    No one assigned
    Labels
    extension-modules C modules in the Modules dir pending The issue will be closed if no feedback is provided topic-XML type-feature A feature request or enhancement
    Projects
    None yet
    Milestone
    No milestone
    Development

    No branches or pull requests
    3 participants
    @tiran @amauryfa @iritkatriel