Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Minor word-choice improvement in devguide "lifecycle of a patch" opening paragraph #56077

Closed
carljm opened this issue Apr 18, 2011 · 2 comments
Closed

Minor word-choice improvement in devguide "lifecycle of a patch" opening paragraph #56077

carljm opened this issue Apr 18, 2011 · 2 comments
Labels
docs Documentation in the Doc dir

Comments

@carljm
Copy link
Member

carljm commented Apr 18, 2011

BPO 11868
Nosy @ned-deily, @carljm
Files
  • svn-like-wording.diff
    		•

    Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.

    Show more details

    GitHub fields:

    assignee = None
closed_at = <Date 2011-04-18.18:31:51.369>
created_at = <Date 2011-04-18.16:09:44.272>
labels = ['docs']
title = 'Minor word-choice improvement in devguide "lifecycle of a patch" opening paragraph'
updated_at = <Date 2011-04-18.18:31:51.367>
user = 'https://github.com/carljm'

    bugs.python.org fields:

    activity = <Date 2011-04-18.18:31:51.367>
actor = 'ned.deily'
assignee = 'none'
closed = True
closed_date = <Date 2011-04-18.18:31:51.369>
closer = 'ned.deily'
components = ['Devguide']
creation = <Date 2011-04-18.16:09:44.272>
creator = 'carljm'
dependencies = []
files = ['21707']
hgrepos = []
issue_num = 11868
keywords = ['patch']
message_count = 2.0
messages = ['133978', '133988']
nosy_count = 2.0
nosy_names = ['ned.deily', 'carljm']
pr_nums = []
priority = 'normal'
resolution = 'fixed'
stage = 'resolved'
status = 'closed'
superseder = None
type = None
url = 'https://bugs.python.org/issue11868'
versions = ['3rd party']
    @carljm
    Copy link
    Member Author

    carljm commented Apr 18, 2011

    The opening paragraph of the "lifecycle of a patch" devguide page contains a confusing parenthetical aside implying that an "svn-like" workflow would mean never *saving* anything to your working copy and using "hg diff" to generate a patch. This is obviously wrong given the usual meaning of "save": if you never save anything to your working copy, "hg diff" will be empty.

    Patch attached with proposed alternative wording.

    @carljm carljm added the docs Documentation in the Doc dir label Apr 18, 2011
    @ned-deily
    Copy link
    Member

    Thanks for the improvement. Applied in changeset cc43ed7af5f2.

    @ezio-melotti ezio-melotti transferred this issue from another repository Apr 10, 2022
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Assignees
    No one assigned
    Labels
    docs Documentation in the Doc dir
    Projects
    None yet
    Milestone
    No milestone
    Development

    No branches or pull requests
    2 participants
    @carljm @ned-deily