Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test fixes for immutable bytes change #45525

Closed
hupp mannequin opened this issue Sep 20, 2007 · 4 comments
Closed

test fixes for immutable bytes change #45525

hupp mannequin opened this issue Sep 20, 2007 · 4 comments
Assignees
@gvanrossum
Labels
interpreter-core (Objects, Python, Grammar, and Parser dirs) stdlib Python modules in the Lib dir

Comments

@hupp
Copy link
Mannequin

hupp mannequin commented Sep 20, 2007

BPO 1184
Nosy @gvanrossum
Files
  • immutable-bytes-test-fix.patch
  • messy_immutable_bytes.patch
    		•

    Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.

    Show more details

    GitHub fields:

    assignee = 'https://github.com/gvanrossum'
closed_at = <Date 2007-11-02.22:58:50.447>
created_at = <Date 2007-09-20.22:38:04.149>
labels = ['interpreter-core', 'library']
title = 'test fixes for immutable bytes change'
updated_at = <Date 2008-01-06.22:29:45.569>
user = 'https://bugs.python.org/hupp'

    bugs.python.org fields:

    activity = <Date 2008-01-06.22:29:45.569>
actor = 'admin'
assignee = 'gvanrossum'
closed = True
closed_date = <Date 2007-11-02.22:58:50.447>
closer = 'gvanrossum'
components = ['Interpreter Core', 'Library (Lib)']
creation = <Date 2007-09-20.22:38:04.149>
creator = 'hupp'
dependencies = []
files = ['8453', '8467']
hgrepos = []
issue_num = 1184
keywords = ['patch']
message_count = 4.0
messages = ['56066', '56127', '56128', '57075']
nosy_count = 3.0
nosy_names = ['gvanrossum', 'hupp', 'jyasskin']
pr_nums = []
priority = 'normal'
resolution = 'out of date'
stage = None
status = 'closed'
superseder = None
type = None
url = 'https://bugs.python.org/issue1184'
versions = ['Python 3.0']
    @hupp
    Copy link
    Mannequin Author

    hupp mannequin commented Sep 20, 2007

    This patch resolves most of the test failures introduced by Jeffrey
    Yasskin's immutable bytes change.

    The remaining failures are:

    test_io
    test_mailbox
    test_mhlib
    test_old_mailbox
    test_email
    test_univnewlines

    The first 4 are the same problem. An array('B') is passed to
    PyArg_ParseTuple("t#..."). This results in "TypeError: Cannot be a
    character buffer" from ascii_decode in _codecsmodule.c.

    Note: This patch is also includes Jeffrey's original changes.

    @hupp hupp mannequin added interpreter-core (Objects, Python, Grammar, and Parser dirs) stdlib Python modules in the Lib dir labels Sep 20, 2007
    @jyasskin
    Copy link
    Mannequin

    jyasskin mannequin commented Sep 25, 2007

    The attached patch (mostly based on hupp's test fixes) passes all of the
    tests on my machine. The issue with ParseTuple is described in
    http://bugs.python.org/issue1200. I intend to clean the patch up some,
    but this is enough to see what the issues tend to be.

    @jyasskin
    Copy link
    Mannequin

    jyasskin mannequin commented Sep 25, 2007

    To be precise, this change makes bytes immutable but does not give it a
    __hash__ method or change the values its iterator returns.

    @gvanrossum
    Copy link
    Member

    This has been superseded by PEP-3137 and the work I've done in the
    py3k-pep3137 branch.

    @ezio-melotti ezio-melotti transferred this issue from another repository Apr 10, 2022
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Assignees

    @gvanrossum gvanrossum

    Labels
    interpreter-core (Objects, Python, Grammar, and Parser dirs) stdlib Python modules in the Lib dir
    Projects
    None yet
    Milestone
    No milestone
    Development

    No branches or pull requests
    1 participant
    @gvanrossum