Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

freeze.py broken due to ABI flags #56033

Closed
Trundle mannequin opened this issue Apr 11, 2011 · 6 comments
Closed

freeze.py broken due to ABI flags #56033

Trundle mannequin opened this issue Apr 11, 2011 · 6 comments
Assignees
@meadori
Labels
type-bug An unexpected behavior, bug, or error

Comments

@Trundle
Copy link
Mannequin

Trundle mannequin commented Apr 11, 2011

BPO 11824
Nosy @loewis, @warsaw, @jcea, @pitrou, @merwok, @Trundle, @meadori
Files
  • freeze.patch
  • issue11824-0.patch
    		•

    Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.

    Show more details

    GitHub fields:

    assignee = 'https://github.com/meadori'
closed_at = <Date 2014-03-30.18:31:23.037>
created_at = <Date 2011-04-11.02:21:58.964>
labels = ['type-bug']
title = 'freeze.py broken due to ABI flags'
updated_at = <Date 2014-03-30.18:31:23.035>
user = 'https://github.com/Trundle'

    bugs.python.org fields:

    activity = <Date 2014-03-30.18:31:23.035>
actor = 'loewis'
assignee = 'meador.inge'
closed = True
closed_date = <Date 2014-03-30.18:31:23.037>
closer = 'loewis'
components = ['Demos and Tools']
creation = <Date 2011-04-11.02:21:58.964>
creator = 'Trundle'
dependencies = []
files = ['21609', '28519']
hgrepos = []
issue_num = 11824
keywords = ['patch']
message_count = 6.0
messages = ['133495', '140457', '166255', '178769', '215193', '215194']
nosy_count = 9.0
nosy_names = ['loewis', 'barry', 'jcea', 'pitrou', 'eric.araujo', 'Arfrever', 'Trundle', 'meador.inge', 'python-dev']
pr_nums = []
priority = 'high'
resolution = 'fixed'
stage = 'patch review'
status = 'closed'
superseder = None
type = 'behavior'
url = 'https://bugs.python.org/issue11824'
versions = ['Python 3.2', 'Python 3.3']
    @Trundle
    Copy link
    Mannequin Author

    Trundle mannequin commented Apr 11, 2011

    The recent addition of ABI flags broke the freeze tool as it doesn't construct the paths to required files correctly any longer. The attached patch fixes the issue for me, but I'm not too sure that I used the right config values.

    @Trundle Trundle mannequin added the type-bug An unexpected behavior, bug, or error label Apr 11, 2011
    @pitrou
    Copy link
    Member

    pitrou commented Jul 15, 2011

    Barry?

    Additionally, if would be nice if we got some tests for the "freeze" tool, otherwise I fear we will keep breaking it.

    @jcea
    Copy link
    Member

    jcea commented Jul 24, 2012

    Ping!

    @meadori
    Copy link
    Member

    meadori commented Jan 1, 2013

    I don't think the current patch is correct. It breaks the usage of freeze.py -p $path since LIBDIR and LIBRARY are blindly used.

    Maybe something like the attached that respects -p and -P can be used instead?

    As for the testing, I think a reasonable solution to get started with is to add some buildbot runs that automate the hello.py freeze on various hosts. That will give us some basic coverage and then more tests can be added over time if need be. I would be happy to help set that up (with given guidance on how to access the buildbots).

    Even with the attached patch I still can't fully build (on OS X 10.7.5) because of bpo-16047:

    Undefined symbols for architecture x86_64:
    "_PyInit__imp", referenced from:
    __PyImport_Inittab in config.o
    ld: symbol(s) not found for architecture x86_64

    I will take a look at that issue next.

    @meadori meadori self-assigned this Jan 1, 2013
    @python-dev
    Copy link
    Mannequin

    python-dev mannequin commented Mar 30, 2014

    New changeset 4e37a4a036c6 by Martin v. Löwis in branch '3.4':
    Issue bpo-11824: Consider ABI tags in freeze. Patch by Meador Inge.
    http://hg.python.org/cpython/rev/4e37a4a036c6

    New changeset 1b6fc88ae3f5 by Martin v. Löwis in branch 'default':
    Merge 3.4: Issue bpo-11824: Consider ABI tags in freeze. Patch by Meador Inge.
    http://hg.python.org/cpython/rev/1b6fc88ae3f5

    @loewis
    Copy link
    Mannequin

    loewis mannequin commented Mar 30, 2014

    Thanks for the patch. Closing this issue as it only deals with the ABI flags; the remaining issues with freeze are dealt with elsewhere.

    @loewis loewis mannequin closed this as completed Mar 30, 2014
    @ezio-melotti ezio-melotti transferred this issue from another repository Apr 10, 2022
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Assignees

    @meadori meadori

    Labels
    type-bug An unexpected behavior, bug, or error
    Projects
    None yet
    Milestone
    No milestone
    Development

    No branches or pull requests
    3 participants
    @meadori @jcea @pitrou