Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename PyBUF_WRITEABLE to PyBUF_WRITABLE #45491

Closed
gvanrossum opened this issue Sep 11, 2007 · 4 comments
Closed

Rename PyBUF_WRITEABLE to PyBUF_WRITABLE #45491

gvanrossum opened this issue Sep 11, 2007 · 4 comments

Comments

@gvanrossum
Copy link
Member

BPO 1150
Nosy @gvanrossum
Files
  • py3k-trunk-writeable.patch
    		•

    Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.

    Show more details

    GitHub fields:

    assignee = None
closed_at = <Date 2007-09-17.17:56:12.427>
created_at = <Date 2007-09-11.18:23:03.353>
labels = []
title = 'Rename PyBUF_WRITEABLE to PyBUF_WRITABLE'
updated_at = <Date 2007-09-17.17:57:18.123>
user = 'https://github.com/gvanrossum'

    bugs.python.org fields:

    activity = <Date 2007-09-17.17:57:18.123>
actor = 'jafo'
assignee = 'jafo'
closed = True
closed_date = <Date 2007-09-17.17:56:12.427>
closer = 'jafo'
components = []
creation = <Date 2007-09-11.18:23:03.353>
creator = 'gvanrossum'
dependencies = []
files = ['8442']
hgrepos = []
issue_num = 1150
keywords = ['patch']
message_count = 4.0
messages = ['55830', '55961', '55965', '55971']
nosy_count = 2.0
nosy_names = ['gvanrossum', 'jafo']
pr_nums = []
priority = 'low'
resolution = 'accepted'
stage = None
status = 'closed'
superseder = None
type = None
url = 'https://bugs.python.org/issue1150'
versions = ['Python 3.0']
    @gvanrossum
    Copy link
    Member Author

    Because writeable is not an English word; writable is.

    Other names should be fixed as well.

    @jafo
    Copy link
    Mannequin

    jafo mannequin commented Sep 17, 2007

    Attached is a patch that fixes "writeable". I'm thinking, close this if
    the patch looks ok, and open another for a general "identify
    non-englishisms" ticket, once they're identified a ticket could be
    opened to fix them.

    I fixed only the PyBUF instances but also documents and comments and doc
    strings and printfs where it occurred. Yes? Let me know if it looks
    good to commit.

    Does this need a fix in 2to3?

    @jafo jafo mannequin assigned gvanrossum Sep 17, 2007
    @gvanrossum
    Copy link
    Member Author

    Looks good. Check it in, with one small addition: add

    #define PyBUF_WRITEABLE PyBUF_WRITABLE

    for those NumPy folks who can't help writing the alternate spelling
    ('writeable' *is* in some dictionaries, though it is consistently
    flagged as invalid by spell checkers).

    @gvanrossum gvanrossum assigned jafo and unassigned gvanrossum Sep 17, 2007
    @jafo jafo mannequin closed this as completed Sep 17, 2007
    @jafo
    Copy link
    Mannequin

    jafo mannequin commented Sep 17, 2007

    Comitted as revision 58182, with additional change mentioned by Guido.

    @ezio-melotti ezio-melotti transferred this issue from another repository Apr 10, 2022
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Assignees
    No one assigned
    Labels
    None yet
    Projects
    None yet
    Milestone
    No milestone
    Development

    No branches or pull requests
    1 participant
    @gvanrossum