Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add writelines test coverage in tempfile #55697

Closed
ev mannequin opened this issue Mar 13, 2011 · 5 comments
Closed

Add writelines test coverage in tempfile #55697

ev mannequin opened this issue Mar 13, 2011 · 5 comments
Assignees
@bitdancer
Labels
tests Tests in the Lib/test dir type-bug An unexpected behavior, bug, or error

Comments

@ev
Copy link
Mannequin

ev mannequin commented Mar 13, 2011

BPO 11488
Nosy @birkenfeld, @ezio-melotti, @bitdancer, @briancurtin
Files
  • test_tempfile_writelines.patch: patch against 3.3
    		•

    Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.

    Show more details

    GitHub fields:

    assignee = 'https://github.com/bitdancer'
closed_at = <Date 2011-03-14.14:03:40.198>
created_at = <Date 2011-03-13.23:08:05.374>
labels = ['type-bug', 'tests']
title = 'Add writelines test coverage in tempfile'
updated_at = <Date 2011-03-14.14:03:40.196>
user = 'https://bugs.python.org/ev'

    bugs.python.org fields:

    activity = <Date 2011-03-14.14:03:40.196>
actor = 'r.david.murray'
assignee = 'r.david.murray'
closed = True
closed_date = <Date 2011-03-14.14:03:40.198>
closer = 'r.david.murray'
components = ['Tests']
creation = <Date 2011-03-13.23:08:05.374>
creator = 'ev'
dependencies = []
files = ['21106']
hgrepos = []
issue_num = 11488
keywords = ['patch']
message_count = 5.0
messages = ['130778', '130786', '130803', '130814', '130815']
nosy_count = 6.0
nosy_names = ['georg.brandl', 'ezio.melotti', 'r.david.murray', 'brian.curtin', 'python-dev', 'ev']
pr_nums = []
priority = 'normal'
resolution = 'accepted'
stage = 'resolved'
status = 'closed'
superseder = None
type = 'behavior'
url = 'https://bugs.python.org/issue11488'
versions = []
    @ev
    Copy link
    Mannequin Author

    ev mannequin commented Mar 13, 2011

    Ran coverage.py and noticed that writelines had no coverage in tempfile, so I added it in.

    @ev ev mannequin added tests Tests in the Lib/test dir type-bug An unexpected behavior, bug, or error labels Mar 13, 2011
    @bitdancer
    Copy link
    Member

    Patch looks good to me.

    @bitdancer bitdancer self-assigned this Mar 14, 2011
    @briancurtin
    Copy link
    Member

    Agreed, looks fine.

    @python-dev
    Copy link
    Mannequin

    python-dev mannequin commented Mar 14, 2011

    New changeset f816841bab03 by R David Murray in branch '3.1':
    bpo-11488: Add tests for writelines method of SpooledTemporaryFile.
    http://hg.python.org/cpython/rev/f816841bab03

    New changeset da37cc4bd088 by R David Murray in branch '3.2':
    Merge bpo-11488 patch from 3.1.
    http://hg.python.org/cpython/rev/da37cc4bd088

    New changeset 7942f613ea5c by R David Murray in branch 'default':
    Merge bpo-11488 patch from 3.2.
    http://hg.python.org/cpython/rev/7942f613ea5c

    New changeset 7aee0fe6ae5d by R David Murray in branch '2.7':
    Port bpo-11488 patch from 3.1 (changeset f816841bab03)
    http://hg.python.org/cpython/rev/7aee0fe6ae5d

    @bitdancer
    Copy link
    Member

    Thanks, Evan.

    @ezio-melotti ezio-melotti transferred this issue from another repository Apr 10, 2022
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Assignees

    @bitdancer bitdancer

    Labels
    tests Tests in the Lib/test dir type-bug An unexpected behavior, bug, or error
    Projects
    None yet
    Milestone
    No milestone
    Development

    No branches or pull requests
    2 participants
    @briancurtin @bitdancer