Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

poplib suppresses exception on QUIT #55500

Closed
giampaolo opened this issue Feb 22, 2011 · 2 comments
Closed

poplib suppresses exception on QUIT #55500

giampaolo opened this issue Feb 22, 2011 · 2 comments
Labels
stdlib Python modules in the Lib dir

Comments

@giampaolo
Copy link
Contributor

BPO 11291
Nosy @pitrou, @giampaolo
Files
  • poplib_quit.patch
  • Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.

    Show more details

    GitHub fields:

    assignee = None
    closed_at = <Date 2011-02-25.22:28:51.961>
    created_at = <Date 2011-02-22.19:52:41.154>
    labels = ['library']
    title = 'poplib suppresses exception on QUIT'
    updated_at = <Date 2011-02-25.22:28:51.958>
    user = 'https://github.com/giampaolo'

    bugs.python.org fields:

    activity = <Date 2011-02-25.22:28:51.958>
    actor = 'giampaolo.rodola'
    assignee = 'none'
    closed = True
    closed_date = <Date 2011-02-25.22:28:51.961>
    closer = 'giampaolo.rodola'
    components = ['Library (Lib)']
    creation = <Date 2011-02-22.19:52:41.154>
    creator = 'giampaolo.rodola'
    dependencies = []
    files = ['20846']
    hgrepos = []
    issue_num = 11291
    keywords = ['patch']
    message_count = 2.0
    messages = ['129114', '129446']
    nosy_count = 2.0
    nosy_names = ['pitrou', 'giampaolo.rodola']
    pr_nums = []
    priority = 'normal'
    resolution = 'fixed'
    stage = None
    status = 'closed'
    superseder = None
    type = None
    url = 'https://bugs.python.org/issue11291'
    versions = ['Python 3.3']

    @giampaolo
    Copy link
    Contributor Author

    Unlike ftplib, smtplib and probably others, poplib suppresses error_proto exceptions on quit().
    I'm not sure in what circumstances a POP3 server can return a negative response on QUIT but if this happens poplib should raise an exception.
    Users who don't care about QUIT response can use the new close() method.
    For backward compatibility patch should only be applied to Python 3.3 .

    @giampaolo
    Copy link
    Contributor Author

    Fixed in r88620.

    @giampaolo giampaolo added the stdlib Python modules in the Lib dir label Feb 25, 2011
    @ezio-melotti ezio-melotti transferred this issue from another repository Apr 10, 2022
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Labels
    stdlib Python modules in the Lib dir
    Projects
    None yet
    Development

    No branches or pull requests

    1 participant