Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

mailbox fails to round-trip a file to a Babyl mailbox #55271

Closed
bitdancer opened this issue Jan 29, 2011 · 8 comments
Closed

mailbox fails to round-trip a file to a Babyl mailbox #55271

bitdancer opened this issue Jan 29, 2011 · 8 comments
Assignees
@akheron
Labels
easy stdlib Python modules in the Lib dir type-bug An unexpected behavior, bug, or error

Comments

@bitdancer
Copy link
Member

BPO 11062
Nosy @bitdancer, @asvetlov, @akheron

Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.

Show more details

GitHub fields:

assignee = 'https://github.com/akheron'
closed_at = <Date 2012-08-16.09:40:16.193>
created_at = <Date 2011-01-29.16:19:35.733>
labels = ['easy', 'type-bug', 'library']
title = 'mailbox fails to round-trip a file to a Babyl mailbox'
updated_at = <Date 2012-08-16.20:58:27.742>
user = 'https://github.com/bitdancer'

bugs.python.org fields:

activity = <Date 2012-08-16.20:58:27.742>
actor = 'asvetlov'
assignee = 'petri.lehtinen'
closed = True
closed_date = <Date 2012-08-16.09:40:16.193>
closer = 'petri.lehtinen'
components = ['Library (Lib)']
creation = <Date 2011-01-29.16:19:35.733>
creator = 'r.david.murray'
dependencies = []
files = []
hgrepos = []
issue_num = 11062
keywords = ['easy']
message_count = 8.0
messages = ['127434', '168277', '168282', '168324', '168326', '168347', '168366', '168409']
nosy_count = 4.0
nosy_names = ['r.david.murray', 'asvetlov', 'python-dev', 'petri.lehtinen']
pr_nums = []
priority = 'normal'
resolution = 'fixed'
stage = 'resolved'
status = 'closed'
superseder = None
type = 'behavior'
url = 'https://bugs.python.org/issue11062'
versions = ['Python 2.7', 'Python 3.2', 'Python 3.3']
@bitdancer
Copy link
Member Author

One of the new tests introduced for bpo-9124 fails for the Bably mailbox format. The failing tests pass a file to the add method (test_add_binary_file, test_add_nonascii_binary_file, test_add_text_file_warns). The failing part of the tests have been temporarily disabled for the Bably mailbox format since it is a pre-existing, unreported bug.

@bitdancer bitdancer added stdlib Python modules in the Lib dir easy type-bug An unexpected behavior, bug, or error labels Jan 29, 2011
@akheron
Copy link
Member

akheron commented Aug 15, 2012

This happens because of a bug in Babyl._install_message(). When adding a message from file, the "*** EOOH ***" line is written also after the second set of headers.

@python-dev
Copy link
Mannequin

python-dev mannequin commented Aug 15, 2012

New changeset ad8c9725c041 by Petri Lehtinen in branch '2.7':
bpo-11062: Fix adding a message from file to Babyl mailbox
http://hg.python.org/cpython/rev/ad8c9725c041

New changeset cbc1dc8cda06 by Petri Lehtinen in branch '3.2':
bpo-11062: Fix adding a message from file to Babyl mailbox
http://hg.python.org/cpython/rev/cbc1dc8cda06

New changeset 7c8c6b905a18 by Petri Lehtinen in branch 'default':
bpo-11062: Fix adding a message from file to Babyl mailbox
http://hg.python.org/cpython/rev/7c8c6b905a18

@akheron akheron closed this as completed Aug 15, 2012
@asvetlov
Copy link
Contributor

Reopen the issue because Windows tests is failed.

Commits for this issue breaks Windows buildbot for 3.2 and 3.3.
Looks like problem is: Windows os.linesep different than Unix.

I don't know what format expected by protocol.

@asvetlov asvetlov reopened this Aug 15, 2012
@akheron
Copy link
Member

akheron commented Aug 15, 2012

Yeah. Enabling the Babyl tests discovered yet another bug on a code path that wasn't excercised at all. I'll fix it.

@akheron akheron self-assigned this Aug 15, 2012
@python-dev
Copy link
Mannequin

python-dev mannequin commented Aug 16, 2012

New changeset 770ffc91a82e by Petri Lehtinen in branch '3.2':
bpo-11062: Fix universal newline support in Babyl._install_message()
http://hg.python.org/cpython/rev/770ffc91a82e

New changeset 5206b9dbf1ac by Petri Lehtinen in branch 'default':
bpo-11062: Fix universal newline support in Babyl._install_message()
http://hg.python.org/cpython/rev/5206b9dbf1ac

@akheron
Copy link
Member

akheron commented Aug 16, 2012

Tests are now passing on Windows, too. Closing.

@akheron akheron closed this as completed Aug 16, 2012
@asvetlov
Copy link
Contributor

Thank you, Petri.

@ezio-melotti ezio-melotti transferred this issue from another repository Apr 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@akheron akheron

Labels
easy stdlib Python modules in the Lib dir type-bug An unexpected behavior, bug, or error
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@akheron @asvetlov @bitdancer