Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove last traces of -Q / sys.flags.division_warning / Py_DivisionWarningFlag #55207

Closed
merwok opened this issue Jan 24, 2011 · 9 comments
Closed

Remove last traces of -Q / sys.flags.division_warning / Py_DivisionWarningFlag #55207

merwok opened this issue Jan 24, 2011 · 9 comments
Assignees
@merwok
Labels
interpreter-core (Objects, Python, Grammar, and Parser dirs) type-bug An unexpected behavior, bug, or error

Comments

@merwok
Copy link
Member

merwok commented Jan 24, 2011

BPO 10998
Nosy @birkenfeld, @rhettinger, @benjaminp, @merwok
Files
  • division_warning.diff
    		•

    Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.

    Show more details

    GitHub fields:

    assignee = 'https://github.com/merwok'
closed_at = <Date 2011-03-26.01:11:54.690>
created_at = <Date 2011-01-24.19:25:49.768>
labels = ['interpreter-core', 'type-bug']
title = 'Remove last traces of -Q / sys.flags.division_warning / Py_DivisionWarningFlag'
updated_at = <Date 2011-04-27.14:37:37.139>
user = 'https://github.com/merwok'

    bugs.python.org fields:

    activity = <Date 2011-04-27.14:37:37.139>
actor = 'python-dev'
assignee = 'eric.araujo'
closed = True
closed_date = <Date 2011-03-26.01:11:54.690>
closer = 'eric.araujo'
components = ['Interpreter Core']
creation = <Date 2011-01-24.19:25:49.768>
creator = 'eric.araujo'
dependencies = []
files = ['20505']
hgrepos = []
issue_num = 10998
keywords = ['patch', 'needs review']
message_count = 9.0
messages = ['126943', '126944', '126951', '126961', '126992', '132196', '132199', '132202', '134569']
nosy_count = 5.0
nosy_names = ['georg.brandl', 'rhettinger', 'benjamin.peterson', 'eric.araujo', 'python-dev']
pr_nums = []
priority = 'normal'
resolution = 'fixed'
stage = 'resolved'
status = 'closed'
superseder = None
type = 'behavior'
url = 'https://bugs.python.org/issue10998'
versions = ['Python 3.3']
    @merwok
    Copy link
    Member Author

    merwok commented Jan 24, 2011

    The -Q command-line option has been removed in Python 3 but there are some leftovers. Attached patch removes them; tests pass; please review.

    I think 3.1 should be fixed too, since no sane program should use those leftovers.

    I removed the now-pointless tests in test_cmd_line. They were not failing; this may be a bug in verify_valid_flag, out of scope for this report.

    While I was editing the table used to document sys.flags, I added some link-generating markup (to the respective option doc) and made the table markup easier to read and edit. I can make those changes in another commit if you prefer it.

    @merwok merwok self-assigned this Jan 24, 2011
    @merwok merwok added interpreter-core (Objects, Python, Grammar, and Parser dirs) type-bug An unexpected behavior, bug, or error labels Jan 24, 2011
    @birkenfeld
    Copy link
    Member

    This would have been good for 3.2, but it is an API change...

    @rhettinger
    Copy link
    Contributor

    I'm in mildly in favor of getting this done before the next release candidate. It seems like a desirable clean-up that would better be done sooner than later.

    @merwok
    Copy link
    Member Author

    merwok commented Jan 24, 2011

    My argument that this change should have no impact so it’s safe to commit also works the other way: there is no pressure to make an exception to the process and commit this after rc1. 3.1 and 3.2 will have the bug, 3.3 won’t.

    @birkenfeld
    Copy link
    Member

    You can even argue it's a bug fix for 3.2.1, but I'd rather keep the list of changes in the rc small.

    @python-dev
    Copy link
    Mannequin

    python-dev mannequin commented Mar 26, 2011

    New changeset 0d2ef718ae67 by Éric Araujo in branch '3.1':
    Tweaks to sys.flags description table.
    http://hg.python.org/cpython/rev/0d2ef718ae67

    New changeset c19752ea037f by Éric Araujo in branch 'default':
    Remove traces of division_warning left over from Python 2 (bpo-10998)
    http://hg.python.org/cpython/rev/c19752ea037f

    @merwok
    Copy link
    Member Author

    merwok commented Mar 26, 2011

    Given your approval of the idea and lack of code comments, I committed the patch for 3.3 without requesting more review.

    @merwok merwok closed this as completed Mar 26, 2011
    @python-dev
    Copy link
    Mannequin

    python-dev mannequin commented Mar 26, 2011

    New changeset 814599728ac0 by Éric Araujo in branch '2.7':
    Tweaks to sys.flags description table.
    http://hg.python.org/cpython/rev/814599728ac0

    @python-dev
    Copy link
    Mannequin

    python-dev mannequin commented Apr 27, 2011

    New changeset f9e2b2b17e58 by Éric Araujo in branch 'default':
    Add versionchanged for c19752ea037f (bpo-10998)
    http://hg.python.org/cpython/rev/f9e2b2b17e58

    @ezio-melotti ezio-melotti transferred this issue from another repository Apr 10, 2022
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Assignees

    @merwok merwok

    Labels
    interpreter-core (Objects, Python, Grammar, and Parser dirs) type-bug An unexpected behavior, bug, or error
    Projects
    None yet
    Milestone
    No milestone
    Development

    No branches or pull requests
    3 participants
    @birkenfeld @merwok @rhettinger