Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

b'dGVzdA==\n'.decode('base64') raise exception #55016

Closed
yicodeplayer mannequin opened this issue Jan 2, 2011 · 7 comments
Closed

b'dGVzdA==\n'.decode('base64') raise exception #55016

yicodeplayer mannequin opened this issue Jan 2, 2011 · 7 comments
Labels
release-blocker topic-unicode type-bug An unexpected behavior, bug, or error

Comments

@yicodeplayer
Copy link
Mannequin

yicodeplayer mannequin commented Jan 2, 2011

BPO 10807
Nosy @birkenfeld, @abalkin, @vstinner
Files
  • issue10807.patch
  • Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.

    Show more details

    GitHub fields:

    assignee = None
    closed_at = <Date 2011-01-02.19:55:50.517>
    created_at = <Date 2011-01-02.18:22:43.075>
    labels = ['type-bug', 'expert-unicode', 'release-blocker']
    title = "`b'dGVzdA==\\n'.decode('base64')` raise exception"
    updated_at = <Date 2011-01-02.19:55:50.516>
    user = 'https://bugs.python.org/yicodeplayer'

    bugs.python.org fields:

    activity = <Date 2011-01-02.19:55:50.516>
    actor = 'vstinner'
    assignee = 'none'
    closed = True
    closed_date = <Date 2011-01-02.19:55:50.517>
    closer = 'vstinner'
    components = ['Unicode']
    creation = <Date 2011-01-02.18:22:43.075>
    creator = 'yi.codeplayer'
    dependencies = []
    files = ['20225']
    hgrepos = []
    issue_num = 10807
    keywords = ['patch']
    message_count = 7.0
    messages = ['125068', '125072', '125074', '125075', '125076', '125077', '125084']
    nosy_count = 4.0
    nosy_names = ['georg.brandl', 'belopolsky', 'vstinner', 'yi.codeplayer']
    pr_nums = []
    priority = 'release blocker'
    resolution = 'fixed'
    stage = None
    status = 'closed'
    superseder = None
    type = 'behavior'
    url = 'https://bugs.python.org/issue10807'
    versions = ['Python 3.2']

    @yicodeplayer
    Copy link
    Mannequin Author

    yicodeplayer mannequin commented Jan 2, 2011

    >>> b'dGVzdA==\n'.decode('base64')
    Traceback (most recent call last):
      File "<stdin>", line 1, in <module>
      File "../Lib/encodings/base64_codec.py", line 20, in base64_decode
        return (base64.decodebytes(input), len(input))
      File "../Lib/base64.py", line 359, in decodebytes
        raise TypeError("expected bytes, not %s" % s.__class__.__name__)
    TypeError: expected bytes, not memoryview

    @yicodeplayer yicodeplayer mannequin added topic-unicode type-bug An unexpected behavior, bug, or error labels Jan 2, 2011
    @vstinner
    Copy link
    Member

    vstinner commented Jan 2, 2011

    base64, bz2, hex, quopri, rot13, uu and zlib codecs (reintroduced recently by r86934, issue bpo-7475) cannot be used by str.encode/bytes.decode, but with .transform() and .untransform() methods of bytes and str objects. But these methods were removed by r87176.

    The last solution to use base64 codec is:

    >>> import codecs
    >>> codecs.lookup('base64').decode(b'YWJj\n')[0]
    b'abc'
    >>> codecs.lookup('base64').encode(b'YWJj\n')[0]
    b'abc'

    Or simply use directly the base64 module:

    >>> import base64
    >>> base64.decodebytes(b'YWJj\n')
    b'abc'
    >>> base64.encodebytes(b'abc')
    b'YWJj\n'

    base64, bz2, hex, quopri, rot13, uu and zlib codecs should be removed from encodings.aliases (because they introduced a confusion for Python 2 users), or removed completly (because it's easier to use directly the related module, eg. base64 or zlib).

    @vstinner
    Copy link
    Member

    vstinner commented Jan 2, 2011

    bpo-10807.patch just disables hex, base64, ... codecs in aliases (so it's still possible to use they through codecs.lookup()).

    @birkenfeld
    Copy link
    Member

    That does not look like the right patch...

    @vstinner
    Copy link
    Member

    vstinner commented Jan 2, 2011

    Ah yes :-)

    @birkenfeld
    Copy link
    Member

    Looks good, please commit.

    @vstinner
    Copy link
    Member

    vstinner commented Jan 2, 2011

    Looks good, please commit.

    Ok, done: r87642

    @vstinner vstinner closed this as completed Jan 2, 2011
    @ezio-melotti ezio-melotti transferred this issue from another repository Apr 10, 2022
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Labels
    release-blocker topic-unicode type-bug An unexpected behavior, bug, or error
    Projects
    None yet
    Development

    No branches or pull requests

    2 participants