Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Globals / builtins cache #54610

Closed
pitrou opened this issue Nov 12, 2010 · 6 comments
Closed

Globals / builtins cache #54610

pitrou opened this issue Nov 12, 2010 · 6 comments
Labels
3.7 (EOL) end of life interpreter-core (Objects, Python, Grammar, and Parser dirs) performance Performance or resource usage

Comments

@pitrou
Copy link
Member

pitrou commented Nov 12, 2010

BPO 10401
Nosy @birkenfeld, @rhettinger, @abalkin, @pitrou, @vstinner, @ericvsmith, @benjaminp, @alex, @methane, @davidmalcolm
Files
  • globcache5.patch
  • Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.

    Show more details

    GitHub fields:

    assignee = None
    closed_at = <Date 2019-12-25.13:42:25.478>
    created_at = <Date 2010-11-12.21:24:29.912>
    labels = ['interpreter-core', '3.7', 'performance']
    title = 'Globals / builtins cache'
    updated_at = <Date 2019-12-25.13:42:25.477>
    user = 'https://github.com/pitrou'

    bugs.python.org fields:

    activity = <Date 2019-12-25.13:42:25.477>
    actor = 'methane'
    assignee = 'none'
    closed = True
    closed_date = <Date 2019-12-25.13:42:25.478>
    closer = 'methane'
    components = ['Interpreter Core']
    creation = <Date 2010-11-12.21:24:29.912>
    creator = 'pitrou'
    dependencies = []
    files = ['19590']
    hgrepos = []
    issue_num = 10401
    keywords = ['patch']
    message_count = 6.0
    messages = ['121081', '121105', '121147', '121150', '282608', '358864']
    nosy_count = 15.0
    nosy_names = ['jhylton', 'nnorwitz', 'georg.brandl', 'rhettinger', 'belopolsky', 'sdahlbac', 'titanstar', 'pitrou', 'vstinner', 'eric.smith', 'thomaslee', 'benjamin.peterson', 'alex', 'methane', 'dmalcolm']
    pr_nums = []
    priority = 'low'
    resolution = 'fixed'
    stage = 'resolved'
    status = 'closed'
    superseder = None
    type = 'performance'
    url = 'https://bugs.python.org/issue10401'
    versions = ['Python 3.7']

    @pitrou
    Copy link
    Member Author

    pitrou commented Nov 12, 2010

    Here is the Nth patch for a globals/builtins cache. As other caches at the same kind, it shows very small to no gain on non-micro benchmarks, showing that contrary to popular belief, globals/builtins lookup are not a major roadblock in today's Python performance.

    However, this patch could be useful in combination with other optimizations such as bpo-10399. Indeed, using the globals/builtins version id, it is easy and very cheap to detect whether the function pointed to by a global name has changed or not.

    As for micro-benchmarks, they show that there is indeed a good improvement on builtins lookups:

    $ ./python -m timeit "x=len;x=len;x=len;x=len;x=len;x=len;x=len;x=len;x=len;x=len;"
    -> without patch:
    1000000 loops, best of 3: 0.282 usec per loop
    -> with patch:
    10000000 loops, best of 3: 0.183 usec per loop

    @pitrou pitrou added interpreter-core (Objects, Python, Grammar, and Parser dirs) performance Performance or resource usage labels Nov 12, 2010
    @smontanaro
    Copy link
    Contributor

    Might such a cache lay the groundwork for more aggressive optimizations
    by JITs like Unladen Swallow?

    @brettcannon
    Copy link
    Member

    Unladen actually has something like this in place for performance optimizations. Not sure how Antoine's approach differs, though.

    @pitrou
    Copy link
    Member Author

    pitrou commented Nov 13, 2010

    There aren't many possible approaches. The more complex variants of globals caches try to also speedup writes, which is IMO a waste of time since rebinding globals is not a good coding practice, and especially not in the middle of time-critical loops.

    (by the way, the patch only addresses normal functions, but generators would easily benefit from a similar treatment)

    And Skip is right that this would be most useful when paired with a JIT (allowing for aggressive specialization, and possibly inlining).

    @methane
    Copy link
    Member

    methane commented Dec 7, 2016

    dict has ma_version for now.

    @Haypo, how do you think about this patch?
    Would you reimplement global cache? Or may I update this patch?

    @methane methane added the 3.7 (EOL) end of life label Dec 7, 2016
    @methane
    Copy link
    Member

    methane commented Dec 25, 2019

    This is implemented in bpo-26219.

    @methane methane closed this as completed Dec 25, 2019
    @ezio-melotti ezio-melotti transferred this issue from another repository Apr 10, 2022
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Labels
    3.7 (EOL) end of life interpreter-core (Objects, Python, Grammar, and Parser dirs) performance Performance or resource usage
    Projects
    None yet
    Development

    No branches or pull requests

    4 participants