Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Deprecate trace module undocumented API #54580

Closed
abalkin opened this issue Nov 9, 2010 · 4 comments
Closed

Deprecate trace module undocumented API #54580

abalkin opened this issue Nov 9, 2010 · 4 comments
Assignees
@abalkin
Labels
stdlib Python modules in the Lib dir type-feature A feature request or enhancement

Comments

@abalkin
Copy link
Member

abalkin commented Nov 9, 2010

BPO 10371
Nosy @brettcannon, @terryjreedy, @abalkin
Files
  • trace-deprecations.diff
    		•

    Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.

    Show more details

    GitHub fields:

    assignee = 'https://github.com/abalkin'
closed_at = <Date 2010-11-20.18:21:51.733>
created_at = <Date 2010-11-09.02:32:30.886>
labels = ['type-feature', 'library']
title = 'Deprecate trace module undocumented API'
updated_at = <Date 2010-11-20.18:21:51.732>
user = 'https://github.com/abalkin'

    bugs.python.org fields:

    activity = <Date 2010-11-20.18:21:51.732>
actor = 'belopolsky'
assignee = 'belopolsky'
closed = True
closed_date = <Date 2010-11-20.18:21:51.733>
closer = 'belopolsky'
components = ['Library (Lib)']
creation = <Date 2010-11-09.02:32:30.886>
creator = 'belopolsky'
dependencies = []
files = ['19553']
hgrepos = []
issue_num = 10371
keywords = ['patch']
message_count = 4.0
messages = ['120833', '120886', '121028', '121704']
nosy_count = 4.0
nosy_names = ['brett.cannon', 'terry.reedy', 'belopolsky', 'eli.bendersky']
pr_nums = []
priority = 'normal'
resolution = 'accepted'
stage = 'resolved'
status = 'closed'
superseder = None
type = 'enhancement'
url = 'https://bugs.python.org/issue10371'
versions = ['Python 3.2']
    @abalkin
    Copy link
    Member Author

    abalkin commented Nov 9, 2010

    Following python-dev discussion on the issue, I would like to propose trace-deprecations.diff patch for review.

    I would like to make these changes before turning to bpo-10342 which will require changing many of these APIs that take a source path to take a module object (or possibly a loader).

    Note that CoverageResults presents an interesting case of a class that does not need to be public, but its methods, particularly write_results() need to be documented.

    @abalkin abalkin self-assigned this Nov 9, 2010
    @abalkin abalkin added stdlib Python modules in the Lib dir type-feature A feature request or enhancement labels Nov 9, 2010
    @terryjreedy
    Copy link
    Member

    Looks good in a cursory reading. I presume trace test still passes.

    If you change the signature of the renamed functions, that would break the current wrappings. Would you use new private functions with different names, or change the wrappings where possible?

    @elibendersky
    Copy link
    Mannequin

    elibendersky mannequin commented Nov 12, 2010

    Alexander, http://bugs.python.org/file19553/trace-deprecations.diff looks good to me

    @abalkin
    Copy link
    Member Author

    abalkin commented Nov 20, 2010

    Committed in revision 86594.

    @abalkin abalkin closed this as completed Nov 20, 2010
    @ezio-melotti ezio-melotti transferred this issue from another repository Apr 10, 2022
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Assignees

    @abalkin abalkin

    Labels
    stdlib Python modules in the Lib dir type-feature A feature request or enhancement
    Projects
    None yet
    Milestone
    No milestone
    Development

    No branches or pull requests
    2 participants
    @abalkin @terryjreedy