Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve JSON encoding with sort_keys=True #54523

Closed
pitrou opened this issue Nov 4, 2010 · 3 comments
Closed

Improve JSON encoding with sort_keys=True #54523

pitrou opened this issue Nov 4, 2010 · 3 comments
Labels
performance Performance or resource usage stdlib Python modules in the Lib dir

Comments

@pitrou
Copy link
Member

pitrou commented Nov 4, 2010

BPO 10314
Nosy @rhettinger, @pitrou
Files
  • jsonsort.patch
    		•

    Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.

    Show more details

    GitHub fields:

    assignee = None
closed_at = <Date 2010-11-04.16:51:56.319>
created_at = <Date 2010-11-04.16:31:37.158>
labels = ['library', 'performance']
title = 'Improve JSON encoding with sort_keys=True'
updated_at = <Date 2010-11-04.16:51:56.318>
user = 'https://github.com/pitrou'

    bugs.python.org fields:

    activity = <Date 2010-11-04.16:51:56.318>
actor = 'pitrou'
assignee = 'none'
closed = True
closed_date = <Date 2010-11-04.16:51:56.319>
closer = 'pitrou'
components = ['Library (Lib)']
creation = <Date 2010-11-04.16:31:37.158>
creator = 'pitrou'
dependencies = []
files = ['19496']
hgrepos = []
issue_num = 10314
keywords = ['patch']
message_count = 3.0
messages = ['120418', '120419', '120420']
nosy_count = 2.0
nosy_names = ['rhettinger', 'pitrou']
pr_nums = []
priority = 'normal'
resolution = 'fixed'
stage = None
status = 'closed'
superseder = None
type = 'performance'
url = 'https://bugs.python.org/issue10314'
versions = ['Python 3.2']
    @pitrou
    Copy link
    Member Author

    pitrou commented Nov 4, 2010

    This patch makes sorting of keys when encoding a dict into JSON faster by not calling pure Python code.

    @pitrou pitrou added stdlib Python modules in the Lib dir performance Performance or resource usage labels Nov 4, 2010
    @rhettinger
    Copy link
    Contributor

    +1

    @pitrou
    Copy link
    Member Author

    pitrou commented Nov 4, 2010

    Ok, committed in r86169.

    @pitrou pitrou closed this as completed Nov 4, 2010
    @ezio-melotti ezio-melotti transferred this issue from another repository Apr 10, 2022
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Assignees
    No one assigned
    Labels
    performance Performance or resource usage stdlib Python modules in the Lib dir
    Projects
    None yet
    Milestone
    No milestone
    Development

    No branches or pull requests
    2 participants
    @rhettinger @pitrou