Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PATCH] Unicode fixes in floatobject and moduleobject #45364

Closed
erocarrera mannequin opened this issue Aug 25, 2007 · 3 comments
Closed

[PATCH] Unicode fixes in floatobject and moduleobject #45364

erocarrera mannequin opened this issue Aug 25, 2007 · 3 comments

Comments

@erocarrera
Copy link
Mannequin

erocarrera mannequin commented Aug 25, 2007

BPO 1023
Nosy @gvanrossum
Files
  • floatobject_moduleobject_pystring.patch
  • Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.

    Show more details

    GitHub fields:

    assignee = None
    closed_at = <Date 2007-08-29.21:31:07.296>
    created_at = <Date 2007-08-25.18:16:27.565>
    labels = []
    title = '[PATCH] Unicode fixes in floatobject and moduleobject'
    updated_at = <Date 2007-09-02.20:05:03.494>
    user = 'https://bugs.python.org/erocarrera'

    bugs.python.org fields:

    activity = <Date 2007-09-02.20:05:03.494>
    actor = 'loewis'
    assignee = 'none'
    closed = True
    closed_date = <Date 2007-08-29.21:31:07.296>
    closer = 'gvanrossum'
    components = []
    creation = <Date 2007-08-25.18:16:27.565>
    creator = 'ero.carrera'
    dependencies = []
    files = ['8318']
    hgrepos = []
    issue_num = 1023
    keywords = ['patch']
    message_count = 3.0
    messages = ['55291', '55437', '55443']
    nosy_count = 2.0
    nosy_names = ['gvanrossum', 'ero.carrera']
    pr_nums = []
    priority = 'normal'
    resolution = 'duplicate'
    stage = None
    status = 'closed'
    superseder = None
    type = None
    url = 'https://bugs.python.org/issue1023'
    versions = ['Python 3.0']

    @erocarrera
    Copy link
    Mannequin Author

    erocarrera mannequin commented Aug 25, 2007

    Removed calls to _PyUnicode_AsDefaultEncodedString and replaced them
    wit PyUnicode_AsString.
    Also removed calls to PyString_* and replaced them by the equivalent
    PyUnicode_*

    @gvanrossum
    Copy link
    Member

    Is this still relevant? The patch fails applying with quit a bit of
    fireworks:

    patching file moduleobject.c
    Hunk #1 FAILED at 66.
    Hunk #2 succeeded at 86 (offset -5 lines).
    Hunk #3 FAILED at 115.
    Hunk #4 FAILED at 128.
    3 out of 4 hunks FAILED -- saving rejects to file moduleobject.c.rej
    patching file floatobject.c
    Reversed (or previously applied) patch detected! Assume -R? [n] n
    Apply anyway? [n] n
    Skipping patch.
    3 out of 3 hunks ignored -- saving rejects to file floatobject.c.rej

    @erocarrera
    Copy link
    Mannequin Author

    erocarrera mannequin commented Aug 29, 2007

    Just took a look. Seems it was fixed in some other patch hence the fireworks

    @ezio-melotti ezio-melotti transferred this issue from another repository Apr 10, 2022
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Labels
    None yet
    Projects
    None yet
    Development

    No branches or pull requests

    1 participant