Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cleanup pass on _curses and _curses_panel #45360

Closed
larryhastings opened this issue Aug 25, 2007 · 4 comments
Closed

Cleanup pass on _curses and _curses_panel #45360

larryhastings opened this issue Aug 25, 2007 · 4 comments
Labels
extension-modules C modules in the Modules dir type-bug An unexpected behavior, bug, or error

Comments

@larryhastings
Copy link
Contributor

BPO 1019
Nosy @gvanrossum, @akuchling, @birkenfeld, @larryhastings
Files
  • lch.py3k.curses.module.diff.1.txt
    		•

    Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.

    Show more details

    GitHub fields:

    assignee = None
closed_at = <Date 2010-02-22.23:49:17.948>
created_at = <Date 2007-08-25.11:25:16.725>
labels = ['extension-modules', 'type-bug']
title = 'Cleanup pass on _curses and _curses_panel'
updated_at = <Date 2010-02-22.23:49:17.947>
user = 'https://github.com/larryhastings'

    bugs.python.org fields:

    activity = <Date 2010-02-22.23:49:17.947>
actor = 'larry'
assignee = 'none'
closed = True
closed_date = <Date 2010-02-22.23:49:17.948>
closer = 'larry'
components = ['Extension Modules']
creation = <Date 2007-08-25.11:25:16.725>
creator = 'larry'
dependencies = []
files = ['8316']
hgrepos = []
issue_num = 1019
keywords = ['patch']
message_count = 4.0
messages = ['55287', '55435', '55866', '99878']
nosy_count = 4.0
nosy_names = ['gvanrossum', 'akuchling', 'georg.brandl', 'larry']
pr_nums = []
priority = 'low'
resolution = 'rejected'
stage = None
status = 'closed'
superseder = None
type = 'behavior'
url = 'https://bugs.python.org/issue1019'
versions = ['Python 3.0']
    @larryhastings
    Copy link
    Contributor Author

    *BEFORE* APPLYING THIS PATCH, YOU MUST
    % svn move Include/py_curses.h Modules/_py_curses.h
    (A "patch" can't convey that sort of information.)

    I made a pass cleaning up _curses and _curses_panel. Mainly I cleaned
    up the header file, moving unnecessary things into the two .c files.
    I also changed the way information is passed from _curses to
    _curses_panel. Instead of a Py_CObject which points to functions--which
    Neil Norwitz suspected could be a security hole--it now passes cleaner
    information (one type, one int * pointer). Finally, I made a
    code-cleanup pass as per PEP-7.

    @larryhastings larryhastings added extension-modules C modules in the Modules dir type-bug An unexpected behavior, bug, or error labels Aug 25, 2007
    @gvanrossum
    Copy link
    Member

    I tried to run the various demos in Demo/curses/ with the new version.
    They all work except for xmas.py. Before your patch, they all ran.

    So I cannot apply this yet. (No time to look into it further, alas.)

    @birkenfeld
    Copy link
    Member

    Unfortunately, the patch is hard to review with all the whitespace
    cleanup distracting from semantic changes. Can you produce a patch with
    only those changes?

    @akuchling akuchling assigned akuchling and unassigned akuchling Jan 12, 2008
    @larryhastings
    Copy link
    Contributor Author

    The major reason I undertook this patch was to fix the security hole of the CObject. That entire class of security holes is now fixed by the capsule object. The rest of the diffs aren't interesting enough to worry about. So I'm abandoning my patch.

    @ezio-melotti ezio-melotti transferred this issue from another repository Apr 10, 2022
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Assignees
    No one assigned
    Labels
    extension-modules C modules in the Modules dir type-bug An unexpected behavior, bug, or error
    Projects
    None yet
    Milestone
    No milestone
    Development

    No branches or pull requests
    4 participants
    @birkenfeld @akuchling @gvanrossum @larryhastings