Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test_importlib leaves stray registry entries on Windows #90774

Closed
zooba opened this issue Feb 2, 2022 · 4 comments
Closed

test_importlib leaves stray registry entries on Windows #90774

zooba opened this issue Feb 2, 2022 · 4 comments
Assignees
@zooba
Labels
3.9 only security fixes 3.10 only security fixes 3.11 only security fixes OS-windows type-bug An unexpected behavior, bug, or error

Comments

@zooba
Copy link
Member

zooba commented Feb 2, 2022

BPO 46616
Nosy @pfmoore, @tjguk, @zware, @zooba, @miss-islington
PRs
  • bpo-46616: Ensures test_importlib.test_windows cleans up registry keys after completion #31086
  • [3.10] bpo-46616: Ensures test_importlib.test_windows cleans up registry keys after completion (GH-31086) #31087
  • [3.9] bpo-46616: Ensures test_importlib.test_windows cleans up registry keys after completion (GH-31086) #31088
    		•

    Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.

    Show more details

    GitHub fields:

    assignee = 'https://github.com/zooba'
closed_at = <Date 2022-02-02.20:33:48.711>
created_at = <Date 2022-02-02.18:14:06.960>
labels = ['3.10', 'type-bug', '3.9', 'OS-windows', '3.11']
title = 'test_importlib leaves stray registry entries on Windows'
updated_at = <Date 2022-02-02.20:33:48.710>
user = 'https://github.com/zooba'

    bugs.python.org fields:

    activity = <Date 2022-02-02.20:33:48.710>
actor = 'steve.dower'
assignee = 'steve.dower'
closed = True
closed_date = <Date 2022-02-02.20:33:48.711>
closer = 'steve.dower'
components = ['Windows']
creation = <Date 2022-02-02.18:14:06.960>
creator = 'steve.dower'
dependencies = []
files = []
hgrepos = []
issue_num = 46616
keywords = ['patch']
message_count = 4.0
messages = ['412388', '412393', '412397', '412398']
nosy_count = 5.0
nosy_names = ['paul.moore', 'tim.golden', 'zach.ware', 'steve.dower', 'miss-islington']
pr_nums = ['31086', '31087', '31088']
priority = 'normal'
resolution = 'fixed'
stage = 'resolved'
status = 'closed'
superseder = None
type = 'behavior'
url = 'https://bugs.python.org/issue46616'
versions = ['Python 3.9', 'Python 3.10', 'Python 3.11']
    @zooba
    Copy link
    Member Author

    zooba commented Feb 2, 2022

    When running test_importlib.test_windows, it may create registry keys that previously didn't exist. These keys are not fully cleaned up.

    Detect if the full key is created and then delete it after the test. If it existed, only delete the specific test key.

    @zooba zooba added 3.9 only security fixes 3.10 only security fixes 3.11 only security fixes labels Feb 2, 2022
    @zooba zooba self-assigned this Feb 2, 2022
    @zooba zooba added OS-windows type-bug An unexpected behavior, bug, or error 3.9 only security fixes 3.10 only security fixes 3.11 only security fixes labels Feb 2, 2022
    @zooba zooba self-assigned this Feb 2, 2022
    @zooba zooba added OS-windows type-bug An unexpected behavior, bug, or error labels Feb 2, 2022
    @zooba
    Copy link
    Member Author

    zooba commented Feb 2, 2022

    New changeset 89a0a90 by Steve Dower in branch 'main':
    bpo-46616: Ensures test_importlib.test_windows cleans up registry keys after completion (GH-31086)
    89a0a90

    @miss-islington
    Copy link
    Contributor

    New changeset 3c6173c by Miss Islington (bot) in branch '3.9':
    bpo-46616: Ensures test_importlib.test_windows cleans up registry keys after completion (GH-31086)
    3c6173c

    @miss-islington
    Copy link
    Contributor

    New changeset 5765eaa by Miss Islington (bot) in branch '3.10':
    bpo-46616: Ensures test_importlib.test_windows cleans up registry keys after completion (GH-31086)
    5765eaa

    @zooba zooba closed this as completed Feb 2, 2022
    @zooba zooba closed this as completed Feb 2, 2022
    @ezio-melotti ezio-melotti transferred this issue from another repository Apr 10, 2022
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Assignees

    @zooba zooba

    Labels
    3.9 only security fixes 3.10 only security fixes 3.11 only security fixes OS-windows type-bug An unexpected behavior, bug, or error
    Projects
    None yet
    Milestone
    No milestone
    Development

    No branches or pull requests
    2 participants
    @zooba @miss-islington