Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Missing tests for the dis module #89741

Closed
nanjekyejoannah opened this issue Oct 22, 2021 · 12 comments
Closed

Missing tests for the dis module #89741

nanjekyejoannah opened this issue Oct 22, 2021 · 12 comments
Labels
3.11 only security fixes tests Tests in the Lib/test dir

Comments

@nanjekyejoannah
Copy link
Member

BPO 45578
Nosy @taleinat, @ambv, @corona10, @nanjekyejoannah, @sobolevn
PRs
  • bpo-45578: add tests for dis.distb #29332
  • [3.10] bpo-45578: add tests for dis.distb (GH-29332) #29385
  • [3.9] bpo-45578: add tests for dis.distb (GH-29332) #29386
  • bpo-45578: add a test case for dis.findlabels #30058
    		•

    Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.

    Show more details

    GitHub fields:

    assignee = None
closed_at = <Date 2022-01-26.12:39:55.835>
created_at = <Date 2021-10-22.18:15:58.685>
labels = ['tests', '3.11']
title = 'Missing tests for the dis module'
updated_at = <Date 2022-01-26.12:39:55.831>
user = 'https://github.com/nanjekyejoannah'

    bugs.python.org fields:

    activity = <Date 2022-01-26.12:39:55.831>
actor = 'taleinat'
assignee = 'none'
closed = True
closed_date = <Date 2022-01-26.12:39:55.835>
closer = 'taleinat'
components = ['Tests']
creation = <Date 2021-10-22.18:15:58.685>
creator = 'nanjekyejoannah'
dependencies = []
files = []
hgrepos = []
issue_num = 45578
keywords = ['patch']
message_count = 12.0
messages = ['404805', '404809', '404811', '405370', '405373', '405374', '405618', '405622', '405625', '405631', '411726', '411745']
nosy_count = 5.0
nosy_names = ['taleinat', 'lukasz.langa', 'corona10', 'nanjekyejoannah', 'sobolevn']
pr_nums = ['29332', '29385', '29386', '30058']
priority = 'normal'
resolution = 'fixed'
stage = 'resolved'
status = 'closed'
superseder = None
type = None
url = 'https://bugs.python.org/issue45578'
versions = ['Python 3.11']
    @nanjekyejoannah
    Copy link
    Member Author

    I don't see any tests for the following:

    dis.distb
    dis.findlabels

    They are documented, I wonder if it was intentional.

    dis.findlabels is also not dicumented.

    @nanjekyejoannah nanjekyejoannah added 3.11 only security fixes tests Tests in the Lib/test dir labels Oct 22, 2021
    @nanjekyejoannah nanjekyejoannah changed the title Missing tests for he dis module Missing tests for the dis module Oct 22, 2021
    @nanjekyejoannah nanjekyejoannah changed the title Missing tests for he dis module Missing tests for the dis module Oct 22, 2021
    @nanjekyejoannah
    Copy link
    Member Author

    maybe the latter is not a public function.

    @nanjekyejoannah
    Copy link
    Member Author

    It looks like it actually

    @sobolevn
    Copy link
    Member

    I would like to work on it! :)

    Going to send a PR today.

    @sobolevn
    Copy link
    Member

    Looks like findlabels is documented: https://docs.python.org/3/library/dis.html#dis.findlabels

    @nanjekyejoannah
    Copy link
    Member Author

    Yes, it is that's why I added the clarity "It looks like it *is* actually" above

    @ambv
    Copy link
    Contributor

    ambv commented Nov 3, 2021

    New changeset e346f19 by Nikita Sobolev in branch 'main':
    bpo-45578: add tests for dis.distb (GH-29332)
    e346f19

    @sobolevn
    Copy link
    Member

    sobolevn commented Nov 3, 2021

    Only findlabels tests are left!

    @ambv
    Copy link
    Contributor

    ambv commented Nov 3, 2021

    New changeset fd6b70d by Łukasz Langa in branch '3.10':
    [3.10] bpo-45578: add tests for dis.distb (GH-29332) (GH-29385)
    fd6b70d

    @ambv
    Copy link
    Contributor

    ambv commented Nov 3, 2021

    New changeset 8198617 by Łukasz Langa in branch '3.9':
    [3.9] bpo-45578: add tests for dis.distb (GH-29332) (bpo-29386)
    8198617

    @corona10
    Copy link
    Member

    New changeset 84f0939 by Nikita Sobolev in branch 'main':
    bpo-45578: add a test case for dis.findlabels (GH-30058)
    84f0939

    @taleinat
    Copy link
    Contributor

    Thanks for your work on this Nikita!

    @ezio-melotti ezio-melotti transferred this issue from another repository Apr 10, 2022
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Assignees
    No one assigned
    Labels
    3.11 only security fixes tests Tests in the Lib/test dir
    Projects
    None yet
    Milestone
    No milestone
    Development

    No branches or pull requests
    5 participants
    @ambv @taleinat @sobolevn @corona10 @nanjekyejoannah