Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Module xml.parsers.expat.errors misses error code constants of libexpat >=2.0 #89484

Closed
hartwork mannequin opened this issue Sep 29, 2021 · 2 comments
Closed

Module xml.parsers.expat.errors misses error code constants of libexpat >=2.0 #89484

hartwork mannequin opened this issue Sep 29, 2021 · 2 comments
Labels
3.11 only security fixes extension-modules C modules in the Modules dir topic-XML type-feature A feature request or enhancement

Comments

@hartwork
Copy link
Mannequin

hartwork mannequin commented Sep 29, 2021

BPO 45321
Nosy @scoder, @hartwork, @corona10
PRs
  • bpo-45321: Add missing error codes to module xml.parsers.expat.errors #30188
    		•

    Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.

    Show more details

    GitHub fields:

    assignee = None
closed_at = <Date 2021-12-31.09:59:05.370>
created_at = <Date 2021-09-29.12:49:45.497>
labels = ['extension-modules', 'expert-XML', 'type-feature', '3.11']
title = 'Module xml.parsers.expat.errors misses error code constants of libexpat >=2.0'
updated_at = <Date 2021-12-31.09:59:05.366>
user = 'https://github.com/hartwork'

    bugs.python.org fields:

    activity = <Date 2021-12-31.09:59:05.366>
actor = 'scoder'
assignee = 'none'
closed = True
closed_date = <Date 2021-12-31.09:59:05.370>
closer = 'scoder'
components = ['Extension Modules', 'XML']
creation = <Date 2021-09-29.12:49:45.497>
creator = 'sping'
dependencies = []
files = []
hgrepos = []
issue_num = 45321
keywords = ['patch']
message_count = 2.0
messages = ['402866', '409411']
nosy_count = 5.0
nosy_names = ['scoder', 'eli.bendersky', 'python-dev', 'sping', 'corona10']
pr_nums = ['30188']
priority = 'normal'
resolution = 'fixed'
stage = 'resolved'
status = 'closed'
superseder = None
type = 'enhancement'
url = 'https://bugs.python.org/issue45321'
versions = ['Python 3.11']
    @hartwork
    Copy link
    Mannequin Author

    hartwork mannequin commented Sep 29, 2021

    (This has been mention at https://bugs.python.org/issue44394#msg395642 before, but bpo-44394 has been closed as fixed despite that part being forgotten, hence the dedicated ticket...)

    Module xml.parsers.expat.errors and its docs need 6 more error code entries to be complete:

    /* Added in 2.0. */
    38 XML_ERROR_RESERVED_PREFIX_XML
    39 XML_ERROR_RESERVED_PREFIX_XMLNS
    40 XML_ERROR_RESERVED_NAMESPACE_URI

    /* Added in 2.2.1. */
    41 XML_ERROR_INVALID_ARGUMENT

    /* Added in 2.3.0. */
    42 XML_ERROR_NO_BUFFER

    /* Added in 2.4.0. */
    43 XML_ERROR_AMPLIFICATION_LIMIT_BREACH

    The source for this is:

    The place where additions is needed is:

    Thanks in advance.

    @hartwork hartwork mannequin added 3.7 (EOL) end of life 3.8 only security fixes 3.9 only security fixes 3.10 only security fixes 3.11 only security fixes extension-modules C modules in the Modules dir labels Sep 29, 2021
    @scoder
    Copy link
    Contributor

    scoder commented Dec 31, 2021

    New changeset e18d815 by Sebastian Pipping in branch 'main':
    bpo-45321: Add missing error codes to module xml.parsers.expat.errors (GH-30188)
    e18d815

    @scoder scoder added topic-XML and removed 3.7 (EOL) end of life 3.8 only security fixes 3.9 only security fixes 3.10 only security fixes labels Dec 31, 2021
    @scoder scoder closed this as completed Dec 31, 2021
    @scoder scoder added the type-feature A feature request or enhancement label Dec 31, 2021
    @ezio-melotti ezio-melotti transferred this issue from another repository Apr 10, 2022
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Assignees
    No one assigned
    Labels
    3.11 only security fixes extension-modules C modules in the Modules dir topic-XML type-feature A feature request or enhancement
    Projects
    None yet
    Milestone
    No milestone
    Development

    No branches or pull requests
    1 participant
    @scoder