Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Specialize LOAD_METHOD with PEP 659 adaptive interpreter #89052

Closed
Fidget-Spinner opened this issue Aug 11, 2021 · 3 comments
Closed

Specialize LOAD_METHOD with PEP 659 adaptive interpreter #89052

Fidget-Spinner opened this issue Aug 11, 2021 · 3 comments
Labels
3.11 only security fixes interpreter-core (Objects, Python, Grammar, and Parser dirs)

Comments

@Fidget-Spinner
Copy link
Member

BPO 44889
Nosy @markshannon, @Fidget-Spinner
PRs
  • bpo-44889: Specialize LOAD_METHOD with PEP 659 adaptive interpreter #27722
    		•

    Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.

    Show more details

    GitHub fields:

    assignee = None
closed_at = <Date 2021-08-17.15:26:06.425>
created_at = <Date 2021-08-11.12:43:20.700>
labels = ['interpreter-core', '3.11']
title = 'Specialize LOAD_METHOD with PEP 659 adaptive interpreter'
updated_at = <Date 2021-08-17.15:26:06.425>
user = 'https://github.com/Fidget-Spinner'

    bugs.python.org fields:

    activity = <Date 2021-08-17.15:26:06.425>
actor = 'kj'
assignee = 'none'
closed = True
closed_date = <Date 2021-08-17.15:26:06.425>
closer = 'kj'
components = ['Interpreter Core']
creation = <Date 2021-08-11.12:43:20.700>
creator = 'kj'
dependencies = []
files = []
hgrepos = []
issue_num = 44889
keywords = ['patch']
message_count = 3.0
messages = ['399388', '399758', '399761']
nosy_count = 2.0
nosy_names = ['Mark.Shannon', 'kj']
pr_nums = ['27722']
priority = 'normal'
resolution = 'fixed'
stage = 'resolved'
status = 'closed'
superseder = None
type = None
url = 'https://bugs.python.org/issue44889'
versions = ['Python 3.11']
    @Fidget-Spinner
    Copy link
    Member Author

    Possible specializations:

    • LOAD_METHOD_CACHED
      Cache the method. We only need to check that type(o) and o.__dict__ was not modified.

    • LOAD_METHOD_CLASS
      For classmethods. Less speedup expected.

    • LOAD_METHOD_MODULE
      For module methods. Uncommon (<10%).

    Please see faster-cpython/ideas#81 for more details.

    @Fidget-Spinner Fidget-Spinner added 3.11 only security fixes interpreter-core (Objects, Python, Grammar, and Parser dirs) labels Aug 11, 2021
    @markshannon
    Copy link
    Member

    New changeset 96346cb by Ken Jin in branch 'main':
    bpo-44889: Specialize LOAD_METHOD with PEP-659 adaptive interpreter (GH-27722)
    96346cb

    @Fidget-Spinner
    Copy link
    Member Author

    Some improvements can be made (see #27722 (comment)), but for the most part we're done.

    @ezio-melotti ezio-melotti transferred this issue from another repository Apr 10, 2022
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Assignees
    No one assigned
    Labels
    3.11 only security fixes interpreter-core (Objects, Python, Grammar, and Parser dirs)
    Projects
    None yet
    Milestone
    No milestone
    Development

    No branches or pull requests
    2 participants
    @markshannon @Fidget-Spinner