Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Prohibit passing non-ThreadPoolExecutor executors to loop.set_default_executor following a deprecation #87400

Closed
illia-v mannequin opened this issue Feb 15, 2021 · 3 comments
Closed

Prohibit passing non-ThreadPoolExecutor executors to loop.set_default_executor following a deprecation #87400

illia-v mannequin opened this issue Feb 15, 2021 · 3 comments
Labels
3.11 only security fixes topic-asyncio

Comments

@illia-v
Copy link
Mannequin

illia-v mannequin commented Feb 15, 2021

BPO 43234
Nosy @asvetlov, @serhiy-storchaka, @1st1, @illia-v
PRs
  • bpo-43234: Prohibit non-ThreadPoolExecutor in loop.set_default_executor #24540
    		•

    Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.

    Show more details

    GitHub fields:

    assignee = None
closed_at = <Date 2021-07-01.14:48:27.705>
created_at = <Date 2021-02-15.20:11:41.237>
labels = ['3.11', 'expert-asyncio']
title = 'Prohibit passing non-ThreadPoolExecutor executors to loop.set_default_executor following a deprecation'
updated_at = <Date 2021-07-01.14:48:27.704>
user = 'https://github.com/illia-v'

    bugs.python.org fields:

    activity = <Date 2021-07-01.14:48:27.704>
actor = 'serhiy.storchaka'
assignee = 'none'
closed = True
closed_date = <Date 2021-07-01.14:48:27.705>
closer = 'serhiy.storchaka'
components = ['asyncio']
creation = <Date 2021-02-15.20:11:41.237>
creator = 'illia-v'
dependencies = []
files = []
hgrepos = []
issue_num = 43234
keywords = ['patch']
message_count = 3.0
messages = ['387052', '396815', '396816']
nosy_count = 4.0
nosy_names = ['asvetlov', 'serhiy.storchaka', 'yselivanov', 'illia-v']
pr_nums = ['24540']
priority = 'normal'
resolution = 'fixed'
stage = 'resolved'
status = 'closed'
superseder = None
type = None
url = 'https://bugs.python.org/issue43234'
versions = ['Python 3.11']
    @illia-v
    Copy link
    Mannequin Author

    illia-v mannequin commented Feb 15, 2021

    cpython/Lib/asyncio/base_events.py

    Lines 816 to 821 in a2f0654

    if not isinstance(executor, concurrent.futures.ThreadPoolExecutor):
    warnings.warn(
    'Using the default executor that is not an instance of '
    'ThreadPoolExecutor is deprecated and will be prohibited '
    'in Python 3.9',
    DeprecationWarning, 2)

    Setting non-ThreadPoolExecutor executors was supposed to be prohibited in Python 3.9.

    @illia-v illia-v mannequin added 3.10 only security fixes topic-asyncio labels Feb 15, 2021
    @serhiy-storchaka serhiy-storchaka added 3.11 only security fixes and removed 3.10 only security fixes labels Jun 28, 2021
    @serhiy-storchaka
    Copy link
    Member

    New changeset ddd5f36 by Illia Volochii in branch 'main':
    bpo-43234: Prohibit non-ThreadPoolExecutor in loop.set_default_executor (GH-24540)
    ddd5f36

    @serhiy-storchaka
    Copy link
    Member

    Thank you for your contribution Illia.

    @ezio-melotti ezio-melotti transferred this issue from another repository Apr 10, 2022
    This was referenced Apr 21, 2023
    Closed
    Closed
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Assignees
    No one assigned
    Labels
    3.11 only security fixes topic-asyncio
    Projects
    None yet
    Milestone
    No milestone
    Development

    No branches or pull requests
    1 participant
    @serhiy-storchaka