Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Incorrect reference counting in _ssl.c's _servername_callback() #85424

Closed
ZackerySpytz mannequin opened this issue Jul 9, 2020 · 5 comments
Closed

Incorrect reference counting in _ssl.c's _servername_callback() #85424

ZackerySpytz mannequin opened this issue Jul 9, 2020 · 5 comments
Assignees
@tiran
Labels
3.8 only security fixes 3.9 only security fixes 3.10 only security fixes extension-modules C modules in the Modules dir topic-SSL type-bug An unexpected behavior, bug, or error

Comments

@ZackerySpytz
Copy link
Mannequin

ZackerySpytz mannequin commented Jul 9, 2020

BPO 41252
Nosy @tiran, @ZackerySpytz, @miss-islington
PRs
  • bpo-41252: Fix incorrect refcounting in _ssl.c's _servername_callback() #21407
  • [3.9] bpo-41252: Fix incorrect refcounting in _ssl.c's _servername_callback() (GH-21407) #21410
  • [3.8] bpo-41252: Fix incorrect refcounting in _ssl.c's _servername_callback() (GH-21407) #21411
    		•

    Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.

    Show more details

    GitHub fields:

    assignee = 'https://github.com/tiran'
closed_at = <Date 2020-07-09.10:27:55.374>
created_at = <Date 2020-07-09.03:53:04.265>
labels = ['expert-SSL', 'type-bug', '3.8', '3.9', '3.10', 'extension-modules']
title = "Incorrect reference counting in _ssl.c's _servername_callback()"
updated_at = <Date 2020-07-09.10:27:55.373>
user = 'https://github.com/ZackerySpytz'

    bugs.python.org fields:

    activity = <Date 2020-07-09.10:27:55.373>
actor = 'christian.heimes'
assignee = 'christian.heimes'
closed = True
closed_date = <Date 2020-07-09.10:27:55.374>
closer = 'christian.heimes'
components = ['Extension Modules', 'SSL']
creation = <Date 2020-07-09.03:53:04.265>
creator = 'ZackerySpytz'
dependencies = []
files = []
hgrepos = []
issue_num = 41252
keywords = ['patch']
message_count = 5.0
messages = ['373371', '373389', '373391', '373392', '373393']
nosy_count = 3.0
nosy_names = ['christian.heimes', 'ZackerySpytz', 'miss-islington']
pr_nums = ['21407', '21410', '21411']
priority = 'normal'
resolution = 'fixed'
stage = 'resolved'
status = 'closed'
superseder = None
type = 'behavior'
url = 'https://bugs.python.org/issue41252'
versions = ['Python 3.8', 'Python 3.9', 'Python 3.10']
    @ZackerySpytz
    Copy link
    Mannequin Author

    ZackerySpytz mannequin commented Jul 9, 2020

    In _servername_callback(), servername_bytes will be used after being
    decrefed if PyUnicode_FromEncodedObject() fails.

    @ZackerySpytz ZackerySpytz mannequin added 3.8 only security fixes 3.9 only security fixes 3.10 only security fixes labels Jul 9, 2020
    @ZackerySpytz ZackerySpytz mannequin assigned tiran Jul 9, 2020
    @ZackerySpytz ZackerySpytz mannequin added extension-modules C modules in the Modules dir topic-SSL type-bug An unexpected behavior, bug, or error 3.8 only security fixes 3.9 only security fixes 3.10 only security fixes labels Jul 9, 2020
    @ZackerySpytz ZackerySpytz mannequin assigned tiran Jul 9, 2020
    @ZackerySpytz ZackerySpytz mannequin added extension-modules C modules in the Modules dir topic-SSL type-bug An unexpected behavior, bug, or error labels Jul 9, 2020
    @miss-islington
    Copy link
    Contributor

    New changeset ee96f32 by Zackery Spytz in branch 'master':
    bpo-41252: Fix incorrect refcounting in _ssl.c's _servername_callback() (GH-21407)
    ee96f32

    @miss-islington
    Copy link
    Contributor

    New changeset 54babbe by Miss Islington (bot) in branch '3.8':
    bpo-41252: Fix incorrect refcounting in _ssl.c's _servername_callback() (GH-21407)
    54babbe

    @miss-islington
    Copy link
    Contributor

    New changeset 90584c0 by Miss Islington (bot) in branch '3.9':
    bpo-41252: Fix incorrect refcounting in _ssl.c's _servername_callback() (GH-21407)
    90584c0

    @tiran
    Copy link
    Member

    tiran commented Jul 9, 2020

    Thanks!

    @tiran tiran closed this as completed Jul 9, 2020
    @tiran tiran closed this as completed Jul 9, 2020
    @ezio-melotti ezio-melotti transferred this issue from another repository Apr 10, 2022
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Assignees

    @tiran tiran

    Labels
    3.8 only security fixes 3.9 only security fixes 3.10 only security fixes extension-modules C modules in the Modules dir topic-SSL type-bug An unexpected behavior, bug, or error
    Projects
    None yet
    Milestone
    No milestone
    Development

    No branches or pull requests
    2 participants
    @tiran @miss-islington