Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DefaultSelector fails to detect selector on VMware ESXi #85354

Closed
Akasurde mannequin opened this issue Jul 1, 2020 · 7 comments
Closed

DefaultSelector fails to detect selector on VMware ESXi #85354

Akasurde mannequin opened this issue Jul 1, 2020 · 7 comments
Labels
stdlib Python modules in the Lib dir

Comments

@Akasurde
Copy link
Mannequin

Akasurde mannequin commented Jul 1, 2020

BPO 41182
Nosy @gvanrossum, @ambv, @miss-islington, @Akasurde
PRs
  • bpo-41182 selector: use DefaultSelector based upon implementation #21257
  • [3.9] bpo-41182 selector: use DefaultSelector based upon implementation (GH-21257) #21630
    		•

    Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.

    Show more details

    GitHub fields:

    assignee = None
closed_at = <Date 2020-07-26.15:37:03.905>
created_at = <Date 2020-07-01.11:08:19.733>
labels = ['library']
title = 'DefaultSelector fails to detect selector on VMware ESXi'
updated_at = <Date 2020-07-26.15:37:03.904>
user = 'https://github.com/Akasurde'

    bugs.python.org fields:

    activity = <Date 2020-07-26.15:37:03.904>
actor = 'gvanrossum'
assignee = 'none'
closed = True
closed_date = <Date 2020-07-26.15:37:03.905>
closer = 'gvanrossum'
components = ['Library (Lib)']
creation = <Date 2020-07-01.11:08:19.733>
creator = 'akasurde'
dependencies = []
files = []
hgrepos = []
issue_num = 41182
keywords = ['patch']
message_count = 7.0
messages = ['372746', '373636', '374118', '374153', '374321', '374325', '374328']
nosy_count = 4.0
nosy_names = ['gvanrossum', 'lukasz.langa', 'miss-islington', 'akasurde']
pr_nums = ['21257', '21630']
priority = 'normal'
resolution = 'fixed'
stage = 'resolved'
status = 'closed'
superseder = None
type = None
url = 'https://bugs.python.org/issue41182'
versions = ['Python 3.5']
    @Akasurde
    Copy link
    Mannequin Author

    Akasurde mannequin commented Jul 1, 2020

    When DefaultSelector is used on VMware ESXi, it fails with

    >>> import selectors
>>> selector = selectors.DefaultSelector()
Traceback (most recent call last):
  File "<stdin>", line 1, in <module>
  File "/build/mts/release/bora-4887370/bora/build/esx/release/vmvisor/sys-boot/lib64/python3.5/selectors.py", line 390, in __init__
OSError: [Errno 38] Function not implemented

    After debugging, I found that it is using Selector which is not implemented for ESXi kernel.

    Change DefaultSelector mechanism to use 'select' implementation to choose default selector.

    @Akasurde Akasurde mannequin added stdlib Python modules in the Lib dir labels Jul 1, 2020
    @Akasurde
    Copy link
    Mannequin Author

    Akasurde mannequin commented Jul 14, 2020

    Any news?

    @miss-islington
    Copy link
    Contributor

    New changeset bcd4783 by Abhijeet Kasurde in branch 'master':
    bpo-41182 selector: use DefaultSelector based upon implementation (GH-21257)
    bcd4783

    @gvanrossum
    Copy link
    Member

    Łukasz, what do you think of backporting this to 3.9?

    @ambv
    Copy link
    Contributor

    ambv commented Jul 26, 2020

    This is a bit of a risky change looking at the PR but since it's a bugfix, we should have it for 3.9.0rc1.

    @miss-islington
    Copy link
    Contributor

    New changeset 6e4975a by Miss Islington (bot) in branch '3.9':
    bpo-41182 selector: use DefaultSelector based upon implementation (GH-21257)
    6e4975a

    @gvanrossum
    Copy link
    Member

    Thank you Abhijeet! Looking forward to more of your contributions.

    @ezio-melotti ezio-melotti transferred this issue from another repository Apr 10, 2022
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Assignees
    No one assigned
    Labels
    stdlib Python modules in the Lib dir
    Projects
    None yet
    Milestone
    No milestone
    Development

    No branches or pull requests
    3 participants
    @ambv @gvanrossum @miss-islington