Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use non-ascii file names in tests by default #85241

Closed
serhiy-storchaka opened this issue Jun 21, 2020 · 3 comments
Closed

Use non-ascii file names in tests by default #85241

serhiy-storchaka opened this issue Jun 21, 2020 · 3 comments
Labels
3.9 only security fixes 3.10 only security fixes tests Tests in the Lib/test dir type-feature A feature request or enhancement

Comments

@serhiy-storchaka
Copy link
Member

BPO 41069
Nosy @serhiy-storchaka
PRs
  • bpo-41069: Make TESTFN and the CWD for tests containing non-ascii characters. #21035
  • [3.9] bpo-41069: Make TESTFN and the CWD for tests containing non-ascii characters. (GH-21035). #21156
    		•
    Dependencies
  • bpo-35773: test_bdb fails on non-UTF-8 locale
  • bpo-41068: zipfile: read after write fails for non-ascii files
  • bpo-41074: msilib does not work correctly with non-ASCII names
  • bpo-41094: Audit does not work with non-ASCII data on non-UTF-8 locale
  • bpo-41112: test_peg_generator fails on non-UTF-8 locale
  • bpo-41113: test_warnings fails on non-Western locales
    		•

    Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.

    Show more details

    GitHub fields:

    assignee = None
closed_at = <Date 2020-06-25.17:40:13.012>
created_at = <Date 2020-06-21.21:18:39.017>
labels = ['type-feature', 'tests', '3.9', '3.10']
title = 'Use non-ascii file names in tests by default'
updated_at = <Date 2020-06-25.17:40:13.011>
user = 'https://github.com/serhiy-storchaka'

    bugs.python.org fields:

    activity = <Date 2020-06-25.17:40:13.011>
actor = 'serhiy.storchaka'
assignee = 'none'
closed = True
closed_date = <Date 2020-06-25.17:40:13.012>
closer = 'serhiy.storchaka'
components = ['Tests']
creation = <Date 2020-06-21.21:18:39.017>
creator = 'serhiy.storchaka'
dependencies = ['35773', '41068', '41074', '41094', '41112', '41113']
files = []
hgrepos = []
issue_num = 41069
keywords = ['patch']
message_count = 3.0
messages = ['372022', '372372', '372382']
nosy_count = 1.0
nosy_names = ['serhiy.storchaka']
pr_nums = ['21035', '21156']
priority = 'normal'
resolution = 'fixed'
stage = 'resolved'
status = 'closed'
superseder = None
type = 'enhancement'
url = 'https://bugs.python.org/issue41069'
versions = ['Python 3.9', 'Python 3.10']
    @serhiy-storchaka
    Copy link
    Member Author

    The following PR increases coverage of tests by making some paths non-ascii:

    1. test.support.TESTFN now contains non-ascii characters if possible.
    2. The temporary directory used as current working directory in tests also contains non-ascii characters if possible.

    This helped to catch and fix one bug in zipfile and two bugs in handling PYTHONSTARTUP.

    @serhiy-storchaka serhiy-storchaka added 3.10 only security fixes tests Tests in the Lib/test dir type-feature A feature request or enhancement labels Jun 21, 2020
    @serhiy-storchaka
    Copy link
    Member Author

    New changeset 700cfa8 by Serhiy Storchaka in branch 'master':
    bpo-41069: Make TESTFN and the CWD for tests containing non-ascii characters. (GH-21035)
    700cfa8

    @serhiy-storchaka
    Copy link
    Member Author

    New changeset f925407 by Serhiy Storchaka in branch '3.9':
    [3.9] bpo-41069: Make TESTFN and the CWD for tests containing non-ascii characters. (GH-21035). (GH-21156)
    f925407

    @serhiy-storchaka serhiy-storchaka added the 3.9 only security fixes label Jun 25, 2020
    @serhiy-storchaka serhiy-storchaka added the 3.9 only security fixes label Jun 25, 2020
    @ezio-melotti ezio-melotti transferred this issue from another repository Apr 10, 2022
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Assignees
    No one assigned
    Labels
    3.9 only security fixes 3.10 only security fixes tests Tests in the Lib/test dir type-feature A feature request or enhancement
    Projects
    None yet
    Milestone
    No milestone
    Development

    No branches or pull requests
    1 participant
    @serhiy-storchaka