Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Delete HAVE_SXS protected code #83734

Closed
zooba opened this issue Feb 5, 2020 · 3 comments
Closed

Delete HAVE_SXS protected code #83734

zooba opened this issue Feb 5, 2020 · 3 comments
Labels
3.9 only security fixes easy OS-windows type-feature A feature request or enhancement

Comments

@zooba
Copy link
Member

zooba commented Feb 5, 2020

BPO 39553
Nosy @pfmoore, @tjguk, @zware, @zooba, @ZackerySpytz, @miss-islington
PRs
  • bpo-39553: Delete HAVE_SXS protected code #18356
    		•

    Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.

    Show more details

    GitHub fields:

    assignee = None
closed_at = <Date 2020-02-05.04:57:38.516>
created_at = <Date 2020-02-05.00:45:13.694>
labels = ['easy', 'type-feature', '3.9', 'OS-windows']
title = 'Delete HAVE_SXS protected code'
updated_at = <Date 2020-02-05.04:57:38.515>
user = 'https://github.com/zooba'

    bugs.python.org fields:

    activity = <Date 2020-02-05.04:57:38.515>
actor = 'steve.dower'
assignee = 'none'
closed = True
closed_date = <Date 2020-02-05.04:57:38.516>
closer = 'steve.dower'
components = ['Windows']
creation = <Date 2020-02-05.00:45:13.694>
creator = 'steve.dower'
dependencies = []
files = []
hgrepos = []
issue_num = 39553
keywords = ['patch', 'easy (C)']
message_count = 3.0
messages = ['361393', '361399', '361402']
nosy_count = 6.0
nosy_names = ['paul.moore', 'tim.golden', 'zach.ware', 'steve.dower', 'ZackerySpytz', 'miss-islington']
pr_nums = ['18356']
priority = 'normal'
resolution = 'fixed'
stage = 'resolved'
status = 'closed'
superseder = None
type = 'enhancement'
url = 'https://bugs.python.org/issue39553'
versions = ['Python 3.9']
    @zooba
    Copy link
    Member Author

    zooba commented Feb 5, 2020

    We no longer support SXS manifests, so rather than fixing bpo-37025 in master, let's just delete the code covered by HAVE_SXS completely.

    @zooba zooba added 3.9 only security fixes OS-windows easy type-feature A feature request or enhancement labels Feb 5, 2020
    @ZackerySpytz
    Copy link
    Mannequin

    ZackerySpytz mannequin commented Feb 5, 2020

    I had worked on bpo-37025, so I have submitted a patch for this issue. Please consider taking a look.

    @miss-islington
    Copy link
    Contributor

    New changeset b439a71 by Zackery Spytz in branch 'master':
    bpo-39553: Delete HAVE_SXS protected code (GH-18356)
    b439a71

    @zooba zooba closed this as completed Feb 5, 2020
    @zooba zooba closed this as completed Feb 5, 2020
    @ezio-melotti ezio-melotti transferred this issue from another repository Apr 10, 2022
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Assignees
    No one assigned
    Labels
    3.9 only security fixes easy OS-windows type-feature A feature request or enhancement
    Projects
    None yet
    Milestone
    No milestone
    Development

    No branches or pull requests
    2 participants
    @zooba @miss-islington