Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

json.dump(..., skipkeys=True) has no unit tests #81986

Closed
Julian mannequin opened this issue Aug 9, 2019 · 5 comments
Closed

json.dump(..., skipkeys=True) has no unit tests #81986

Julian mannequin opened this issue Aug 9, 2019 · 5 comments
Labels
3.7 (EOL) end of life 3.8 only security fixes 3.9 only security fixes tests Tests in the Lib/test dir

Comments

@Julian
Copy link
Mannequin

Julian mannequin commented Aug 9, 2019

BPO 37805
Nosy @methane, @Julian, @corona10, @miss-islington
PRs
  • bpo-37805: Add tests for json.dump(..., skipkeys=True) #15489
  • [3.8] bpo-37805: Add tests for json.dump(..., skipkeys=True) (GH-15489) #15507
  • [3.7] bpo-37805: Add tests for json.dump(..., skipkeys=True) (GH-15489) #15508
    		•

    Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.

    Show more details

    GitHub fields:

    assignee = None
closed_at = <Date 2019-08-26.07:35:17.871>
created_at = <Date 2019-08-09.21:54:43.541>
labels = ['3.8', '3.7', 'tests', '3.9']
title = 'json.dump(..., skipkeys=True) has no unit tests'
updated_at = <Date 2019-08-26.07:36:40.570>
user = 'https://github.com/Julian'

    bugs.python.org fields:

    activity = <Date 2019-08-26.07:36:40.570>
actor = 'miss-islington'
assignee = 'none'
closed = True
closed_date = <Date 2019-08-26.07:35:17.871>
closer = 'methane'
components = ['Tests']
creation = <Date 2019-08-09.21:54:43.541>
creator = 'Julian'
dependencies = []
files = []
hgrepos = []
issue_num = 37805
keywords = ['patch']
message_count = 5.0
messages = ['349317', '350495', '350504', '350505', '350507']
nosy_count = 4.0
nosy_names = ['methane', 'Julian', 'corona10', 'miss-islington']
pr_nums = ['15489', '15507', '15508']
priority = 'normal'
resolution = 'fixed'
stage = 'resolved'
status = 'closed'
superseder = None
type = None
url = 'https://bugs.python.org/issue37805'
versions = ['Python 3.7', 'Python 3.8', 'Python 3.9']
    @Julian
    Copy link
    Mannequin Author

    Julian mannequin commented Aug 9, 2019

    Looks like there possibly are upstream tests that could be pulled in with modification:

    https://github.com/simplejson/simplejson/blob/00ed20da4c0e5f0396661f73482418651ff4d8c7/simplejson/tests/test_dump.py#L53-L66

    (Found via https://bitbucket.org/pypy/pypy/issues/3052/json-skipkeys-true-results-in-invalid-json)

    @Julian Julian mannequin added 3.7 (EOL) end of life 3.8 only security fixes 3.9 only security fixes tests Tests in the Lib/test dir labels Aug 9, 2019
    @miss-islington
    Copy link
    Contributor

    New changeset 44cd86b by Miss Islington (bot) (Dong-hee Na) in branch 'master':
    bpo-37805: Add tests for json.dump(..., skipkeys=True) (GH-15489)
    44cd86b

    @miss-islington
    Copy link
    Contributor

    New changeset a387517 by Miss Islington (bot) in branch '3.8':
    bpo-37805: Add tests for json.dump(..., skipkeys=True) (GH-15489)
    a387517

    @methane
    Copy link
    Member

    methane commented Aug 26, 2019

    thanks

    @methane methane closed this as completed Aug 26, 2019
    @miss-islington
    Copy link
    Contributor

    New changeset a976283 by Miss Islington (bot) in branch '3.7':
    bpo-37805: Add tests for json.dump(..., skipkeys=True) (GH-15489)
    a976283

    @ezio-melotti ezio-melotti transferred this issue from another repository Apr 10, 2022
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Assignees
    No one assigned
    Labels
    3.7 (EOL) end of life 3.8 only security fixes 3.9 only security fixes tests Tests in the Lib/test dir
    Projects
    None yet
    Milestone
    No milestone
    Development

    No branches or pull requests
    2 participants
    @methane @miss-islington