Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

IDLE: clarify shell part of highlight sample #81873

Closed
terryjreedy opened this issue Jul 27, 2019 · 5 comments
Closed

IDLE: clarify shell part of highlight sample #81873

terryjreedy opened this issue Jul 27, 2019 · 5 comments
Assignees
@terryjreedy
Labels
3.7 (EOL) end of life 3.8 only security fixes 3.9 only security fixes topic-IDLE type-bug An unexpected behavior, bug, or error

Comments

@terryjreedy
Copy link
Member

BPO 37692
Nosy @terryjreedy, @miss-islington
PRs
  • bpo-37692: Improve highlight config sample #14983
  • [3.7] bpo-37692: Improve highlight config sample (GH-14983) #14990
  • [3.8] bpo-37692: Improve highlight config sample (GH-14983) #14991
    		•

    Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.

    Show more details

    GitHub fields:

    assignee = 'https://github.com/terryjreedy'
closed_at = <Date 2019-07-29.01:39:20.310>
created_at = <Date 2019-07-27.16:49:33.166>
labels = ['3.8', 'expert-IDLE', 'type-bug', '3.7', '3.9']
title = 'IDLE: clarify shell part of highlight sample'
updated_at = <Date 2019-07-29.01:39:20.308>
user = 'https://github.com/terryjreedy'

    bugs.python.org fields:

    activity = <Date 2019-07-29.01:39:20.308>
actor = 'terry.reedy'
assignee = 'terry.reedy'
closed = True
closed_date = <Date 2019-07-29.01:39:20.310>
closer = 'terry.reedy'
components = ['IDLE']
creation = <Date 2019-07-27.16:49:33.166>
creator = 'terry.reedy'
dependencies = []
files = []
hgrepos = []
issue_num = 37692
keywords = ['patch']
message_count = 5.0
messages = ['348548', '348580', '348583', '348584', '348592']
nosy_count = 2.0
nosy_names = ['terry.reedy', 'miss-islington']
pr_nums = ['14983', '14990', '14991']
priority = 'normal'
resolution = 'fixed'
stage = 'resolved'
status = 'closed'
superseder = None
type = 'behavior'
url = 'https://bugs.python.org/issue37692'
versions = ['Python 3.7', 'Python 3.8', 'Python 3.9']
    @terryjreedy
    Copy link
    Member Author

    The 'console' highlight is described as Shell Normal Text. It is the 'normal' text for non-error output *from the shell* (prompt and debug status), but not the 'normal' text, which is used for code.

    Aside from this, the editor section uses examples rather than description, such as 'list' rather than 'builtin'. I think the shell section should also: "Traceback" instead of stderr (which beginners may or may not understand), 'program output' instead of 'stdout'. Removing the two blank line will make room to put these on separate lines, like they actually are.

    @terryjreedy terryjreedy added 3.7 (EOL) end of life 3.8 only security fixes 3.9 only security fixes labels Jul 27, 2019
    @terryjreedy terryjreedy self-assigned this Jul 27, 2019
    @terryjreedy terryjreedy added topic-IDLE type-bug An unexpected behavior, bug, or error labels Jul 27, 2019
    @terryjreedy
    Copy link
    Member Author

    New changeset b222955 by Terry Jan Reedy in branch 'master':
    bpo-37692: Improve highlight config sample (bpo-14983)
    b222955

    @miss-islington
    Copy link
    Contributor

    New changeset d306264 by Miss Islington (bot) in branch '3.7':
    bpo-37692: Improve highlight config sample (GH-14983)
    d306264

    @miss-islington
    Copy link
    Contributor

    New changeset c94386d by Miss Islington (bot) in branch '3.8':
    bpo-37692: Improve highlight config sample (GH-14983)
    c94386d

    @terryjreedy
    Copy link
    Member Author

    A comment on the PR discussed the label changes made.

    @ezio-melotti ezio-melotti transferred this issue from another repository Apr 10, 2022
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Assignees

    @terryjreedy terryjreedy

    Labels
    3.7 (EOL) end of life 3.8 only security fixes 3.9 only security fixes topic-IDLE type-bug An unexpected behavior, bug, or error
    Projects
    None yet
    Milestone
    No milestone
    Development

    No branches or pull requests
    2 participants
    @terryjreedy @miss-islington