Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use threadpool for reading from file for sendfile fallback mode #81461

Closed
asvetlov opened this issue Jun 14, 2019 · 1 comment
Closed

Use threadpool for reading from file for sendfile fallback mode #81461

asvetlov opened this issue Jun 14, 2019 · 1 comment
Labels
3.7 (EOL) end of life 3.8 only security fixes 3.9 only security fixes topic-asyncio type-bug An unexpected behavior, bug, or error

Comments

@asvetlov
Copy link
Contributor

BPO 37280
Nosy @asvetlov, @1st1
PRs
  • bpo-37280: Use threadpool for reading from file in sendfile fallback mode #14076
  • [3.8] bpo-37280: Use threadpool for reading from file in sendfile fallback mode (GH-14076) #14102
  • [3.7] bpo-37280: Use threadpool for reading from file in sendfile fallback mode (GH-14076) #14101
    		•

    Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.

    Show more details

    GitHub fields:

    assignee = None
closed_at = <Date 2019-06-15.11:26:34.630>
created_at = <Date 2019-06-14.10:29:49.113>
labels = ['3.8', 'type-bug', '3.7', '3.9', 'expert-asyncio']
title = 'Use threadpool for reading from file for sendfile fallback mode'
updated_at = <Date 2019-06-15.11:26:34.630>
user = 'https://github.com/asvetlov'

    bugs.python.org fields:

    activity = <Date 2019-06-15.11:26:34.630>
actor = 'asvetlov'
assignee = 'none'
closed = True
closed_date = <Date 2019-06-15.11:26:34.630>
closer = 'asvetlov'
components = ['asyncio']
creation = <Date 2019-06-14.10:29:49.113>
creator = 'asvetlov'
dependencies = []
files = []
hgrepos = []
issue_num = 37280
keywords = ['patch']
message_count = 1.0
messages = ['345574']
nosy_count = 2.0
nosy_names = ['asvetlov', 'yselivanov']
pr_nums = ['14076', '14102', '14101']
priority = 'normal'
resolution = 'fixed'
stage = 'resolved'
status = 'closed'
superseder = None
type = 'behavior'
url = 'https://bugs.python.org/issue37280'
versions = ['Python 3.7', 'Python 3.8', 'Python 3.9']
    @asvetlov
    Copy link
    Contributor Author

    We use thread pool executor for loop.sock_sendfile(), there is no reason to call blocking code for loop.sendfile()

    @asvetlov asvetlov added 3.7 (EOL) end of life 3.8 only security fixes 3.9 only security fixes topic-asyncio type-bug An unexpected behavior, bug, or error labels Jun 14, 2019
    @ezio-melotti ezio-melotti transferred this issue from another repository Apr 10, 2022
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Assignees
    No one assigned
    Labels
    3.7 (EOL) end of life 3.8 only security fixes 3.9 only security fixes topic-asyncio type-bug An unexpected behavior, bug, or error
    Projects
    None yet
    Milestone
    No milestone
    Development

    No branches or pull requests
    1 participant
    @asvetlov