Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Test suite fails when Ipv6 is unavailable #81380

Closed
NophKe mannequin opened this issue Jun 7, 2019 · 10 comments
Closed

Test suite fails when Ipv6 is unavailable #81380

NophKe mannequin opened this issue Jun 7, 2019 · 10 comments
Labels
3.8 only security fixes 3.9 only security fixes tests Tests in the Lib/test dir type-bug An unexpected behavior, bug, or error

Comments

@NophKe
Copy link
Mannequin

NophKe mannequin commented Jun 7, 2019

BPO 37199
Nosy @vstinner, @benjaminp, @asvetlov, @ZackerySpytz, @miss-islington, @NophKe
PRs
  • bpo-37199: Fix test failures when IPv6 is unavailable or disabled #14480
  • [3.8] bpo-37199: Fix test failures when IPv6 is unavailable or disabled (GH-14480) #14486
  • bpo-37199: Replace the early returns added in c2cda63 #14535
  • [3.8] bpo-37199: Replace the early returns added in c2cda63. (GH-14535) #16112
    		•
    Files
  • test_suite_fail.txt: Error_log
    		•

    Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.

    Show more details

    GitHub fields:

    assignee = None
closed_at = <Date 2019-06-30.15:53:48.711>
created_at = <Date 2019-06-07.17:00:30.712>
labels = ['3.8', 'type-bug', 'tests', '3.9']
title = 'Test suite fails when Ipv6 is unavailable'
updated_at = <Date 2019-09-13.16:12:36.025>
user = 'https://github.com/NophKe'

    bugs.python.org fields:

    activity = <Date 2019-09-13.16:12:36.025>
actor = 'miss-islington'
assignee = 'none'
closed = True
closed_date = <Date 2019-06-30.15:53:48.711>
closer = 'asvetlov'
components = ['Tests']
creation = <Date 2019-06-07.17:00:30.712>
creator = 'Nophke'
dependencies = []
files = ['48402']
hgrepos = []
issue_num = 37199
keywords = ['patch']
message_count = 10.0
messages = ['344970', '346917', '346932', '346933', '346934', '346975', '347039', '347040', '352349', '352356']
nosy_count = 6.0
nosy_names = ['vstinner', 'benjamin.peterson', 'asvetlov', 'ZackerySpytz', 'miss-islington', 'Nophke']
pr_nums = ['14480', '14486', '14535', '16112']
priority = 'normal'
resolution = 'fixed'
stage = 'resolved'
status = 'closed'
superseder = None
type = 'behavior'
url = 'https://bugs.python.org/issue37199'
versions = ['Python 3.8', 'Python 3.9']
    @NophKe
    Copy link
    Mannequin Author

    NophKe mannequin commented Jun 7, 2019

    The test suite does not handle an OS that does not have IPv6.
    When Linux kernel is started with argument:

    ipv6.disable=1

    The test suite fails. ( See attached file )

    5 tests failed:
    test_asyncio test_imaplib test_importlib test_socket test_zipapp

    @NophKe NophKe mannequin added 3.9 only security fixes type-bug An unexpected behavior, bug, or error labels Jun 7, 2019
    @ZackerySpytz
    Copy link
    Mannequin

    ZackerySpytz mannequin commented Jun 30, 2019

    I've created a PR for this issue.

    @ZackerySpytz ZackerySpytz mannequin added the tests Tests in the Lib/test dir label Jun 30, 2019
    @asvetlov
    Copy link
    Contributor

    New changeset c2cda63 by Andrew Svetlov (Zackery Spytz) in branch 'master':
    bpo-37199: Fix test failures when IPv6 is unavailable or disabled (bpo-14480)
    c2cda63

    @miss-islington
    Copy link
    Contributor

    New changeset c2684c6 by Miss Islington (bot) in branch '3.8':
    bpo-37199: Fix test failures when IPv6 is unavailable or disabled (GH-14480)
    c2684c6

    @asvetlov
    Copy link
    Contributor

    Thanks!

    @asvetlov asvetlov added the 3.8 only security fixes label Jun 30, 2019
    @vstinner
    Copy link
    Member

    vstinner commented Jul 1, 2019

    Python 3.7 is still supported, if it's a bugfix, 3.7 should be fixed as well:
    https://devguide.python.org/#status-of-python-branches

    Christian Heimes asked for a change after the PR was merged:
    #14480 (review)

    @asvetlov
    Copy link
    Contributor

    asvetlov commented Jul 1, 2019

    Victor, backporting to 3.7 makes merge conflicts.
    Do you think that I should backport manually?

    @vstinner
    Copy link
    Member

    vstinner commented Jul 1, 2019

    Do you think that I should backport manually?

    Zackery Spytz: Can you please try to backport manually to 3.7?

    But I would prefer to wait until Christian's issue is addressed.

    @benjaminp
    Copy link
    Contributor

    New changeset 81319a8 by Benjamin Peterson (Zackery Spytz) in branch 'master':
    bpo-37199: Replace the early returns added in c2cda63. (GH-14535)
    81319a8

    @miss-islington
    Copy link
    Contributor

    New changeset 83c21fd by Miss Islington (bot) in branch '3.8':
    bpo-37199: Replace the early returns added in c2cda63. (GH-14535)
    83c21fd

    @ezio-melotti ezio-melotti transferred this issue from another repository Apr 10, 2022
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Assignees
    No one assigned
    Labels
    3.8 only security fixes 3.9 only security fixes tests Tests in the Lib/test dir type-bug An unexpected behavior, bug, or error
    Projects
    None yet
    Milestone
    No milestone
    Development

    No branches or pull requests
    4 participants
    @vstinner @benjaminp @asvetlov @miss-islington