Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement Py_TPFLAGS_METHOD_DESCRIPTOR #81103

Closed
jdemeyer opened this issue May 15, 2019 · 4 comments
Closed

Implement Py_TPFLAGS_METHOD_DESCRIPTOR #81103

jdemeyer opened this issue May 15, 2019 · 4 comments
Labels
3.8 only security fixes interpreter-core (Objects, Python, Grammar, and Parser dirs) type-feature A feature request or enhancement

Comments

@jdemeyer
Copy link
Contributor

BPO 36922
Nosy @encukou, @methane, @markshannon, @jdemeyer, @miss-islington
PRs
  • bpo-36922: implement Py_TPFLAGS_METHOD_DESCRIPTOR #13338
  • bpo-36922: use Py_TPFLAGS_METHOD_DESCRIPTOR in lookup_maybe_method() #13865
  • [3.8] bpo-36922: use Py_TPFLAGS_METHOD_DESCRIPTOR in lookup_maybe_method() (GH-13865) #14155
  • Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.

    Show more details

    GitHub fields:

    assignee = None
    closed_at = <Date 2019-05-28.12:44:39.400>
    created_at = <Date 2019-05-15.08:39:45.066>
    labels = ['interpreter-core', 'type-feature', '3.8']
    title = 'Implement Py_TPFLAGS_METHOD_DESCRIPTOR'
    updated_at = <Date 2019-06-17.12:12:55.305>
    user = 'https://github.com/jdemeyer'

    bugs.python.org fields:

    activity = <Date 2019-06-17.12:12:55.305>
    actor = 'miss-islington'
    assignee = 'none'
    closed = True
    closed_date = <Date 2019-05-28.12:44:39.400>
    closer = 'petr.viktorin'
    components = ['Interpreter Core']
    creation = <Date 2019-05-15.08:39:45.066>
    creator = 'jdemeyer'
    dependencies = []
    files = []
    hgrepos = []
    issue_num = 36922
    keywords = ['patch']
    message_count = 4.0
    messages = ['342554', '343770', '345848', '345849']
    nosy_count = 5.0
    nosy_names = ['petr.viktorin', 'methane', 'Mark.Shannon', 'jdemeyer', 'miss-islington']
    pr_nums = ['13338', '13865', '14155']
    priority = 'normal'
    resolution = 'fixed'
    stage = 'resolved'
    status = 'closed'
    superseder = None
    type = 'enhancement'
    url = 'https://bugs.python.org/issue36922'
    versions = ['Python 3.8']

    @jdemeyer
    Copy link
    Contributor Author

    The new flag Py_TPFLAGS_METHOD_DESCRIPTOR proposed in PEP-590 is meant for classes whose instances behave like unbound methods. In other words, it's meant for objects supporting the LOAD_METHOD optimization. There are two such classes in CPython: function and method_descriptor. But the goal is to enable more such classes.

    This is independent from the rest of PEP-590 so let's implement it separately.

    @jdemeyer jdemeyer added 3.8 only security fixes interpreter-core (Objects, Python, Grammar, and Parser dirs) type-feature A feature request or enhancement labels May 15, 2019
    @encukou
    Copy link
    Member

    encukou commented May 28, 2019

    New changeset eb65e24 by Petr Viktorin (Jeroen Demeyer) in branch 'master':
    bpo-36922: implement PEP-590 Py_TPFLAGS_METHOD_DESCRIPTOR (GH-13338)
    eb65e24

    @encukou encukou closed this as completed May 28, 2019
    @methane
    Copy link
    Member

    methane commented Jun 17, 2019

    New changeset 2e9954d by Inada Naoki (Jeroen Demeyer) in branch 'master':
    bpo-36922: use Py_TPFLAGS_METHOD_DESCRIPTOR in lookup_maybe_method() (GH-13865)
    2e9954d

    @miss-islington
    Copy link
    Contributor

    New changeset 988fff5 by Miss Islington (bot) in branch '3.8':
    bpo-36922: use Py_TPFLAGS_METHOD_DESCRIPTOR in lookup_maybe_method() (GH-13865)
    988fff5

    @ezio-melotti ezio-melotti transferred this issue from another repository Apr 10, 2022
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Labels
    3.8 only security fixes interpreter-core (Objects, Python, Grammar, and Parser dirs) type-feature A feature request or enhancement
    Projects
    None yet
    Development

    No branches or pull requests

    4 participants