Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

_hashopenssl has reference leaks in OOM case #80360

Closed
tiran opened this issue Mar 4, 2019 · 5 comments
Closed

_hashopenssl has reference leaks in OOM case #80360

tiran opened this issue Mar 4, 2019 · 5 comments
Assignees
@tiran
Labels
3.7 (EOL) end of life 3.8 only security fixes extension-modules C modules in the Modules dir performance Performance or resource usage

Comments

@tiran
Copy link
Member

tiran commented Mar 4, 2019

BPO 36179
Nosy @gpshead, @tiran, @stratakis, @miss-islington, @iritkatriel
PRs
  • bpo-36179: Fix ref leaks in _hashopenssl #12158
  • [3.7] bpo-36179: Fix ref leaks in _hashopenssl (GH-12158) #12164
  • [3.6] bpo-36179: Fix ref leaks in _hashopenssl (GH-12158) #12165
  • [2.7] bpo-36179: Fix ref leaks in _hashopenssl (GH-12158) #12166
    		•

    Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.

    Show more details

    GitHub fields:

    assignee = 'https://github.com/tiran'
closed_at = <Date 2020-10-17.06:26:39.196>
created_at = <Date 2019-03-04.09:41:10.547>
labels = ['extension-modules', '3.7', '3.8', 'performance']
title = '_hashopenssl has reference leaks in OOM case'
updated_at = <Date 2020-10-17.06:26:39.196>
user = 'https://github.com/tiran'

    bugs.python.org fields:

    activity = <Date 2020-10-17.06:26:39.196>
actor = 'gregory.p.smith'
assignee = 'christian.heimes'
closed = True
closed_date = <Date 2020-10-17.06:26:39.196>
closer = 'gregory.p.smith'
components = ['Extension Modules']
creation = <Date 2019-03-04.09:41:10.547>
creator = 'christian.heimes'
dependencies = []
files = []
hgrepos = []
issue_num = 36179
keywords = ['patch']
message_count = 5.0
messages = ['337087', '337133', '337137', '337140', '378766']
nosy_count = 5.0
nosy_names = ['gregory.p.smith', 'christian.heimes', 'cstratak', 'miss-islington', 'iritkatriel']
pr_nums = ['12158', '12164', '12165', '12166']
priority = 'normal'
resolution = 'fixed'
stage = 'resolved'
status = 'closed'
superseder = None
type = 'resource usage'
url = 'https://bugs.python.org/issue36179'
versions = ['Python 2.7', 'Python 3.7', 'Python 3.8']
    @tiran
    Copy link
    Member Author

    tiran commented Mar 4, 2019

    Charalampos Stratakis from Red Hat's Python Maintenance Team found two minor reference leaks in _hashopenssl.c. Ref counts of newly allocated are not decreased when allocation of another object fails.

    @tiran tiran added 3.7 (EOL) end of life 3.8 only security fixes labels Mar 4, 2019
    @tiran tiran self-assigned this Mar 4, 2019
    @tiran tiran added extension-modules C modules in the Modules dir performance Performance or resource usage labels Mar 4, 2019
    @miss-islington
    Copy link
    Contributor

    New changeset b7bc283 by Miss Islington (bot) (Christian Heimes) in branch 'master':
    bpo-36179: Fix ref leaks in _hashopenssl (GH-12158)
    b7bc283

    @miss-islington
    Copy link
    Contributor

    New changeset a59d33a by Miss Islington (bot) in branch '3.7':
    bpo-36179: Fix ref leaks in _hashopenssl (GH-12158)
    a59d33a

    @miss-islington
    Copy link
    Contributor

    New changeset 84b5ac9 by Miss Islington (bot) (Christian Heimes) in branch '2.7':
    [2.7] bpo-36179: Fix ref leaks in _hashopenssl (GH-12158) (GH-12166)
    84b5ac9

    @iritkatriel
    Copy link
    Member

    Can this be closed?

    @gpshead gpshead closed this as completed Oct 17, 2020
    @ezio-melotti ezio-melotti transferred this issue from another repository Apr 10, 2022
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Assignees

    @tiran tiran

    Labels
    3.7 (EOL) end of life 3.8 only security fixes extension-modules C modules in the Modules dir performance Performance or resource usage
    Projects
    None yet
    Milestone
    No milestone
    Development

    No branches or pull requests
    4 participants
    @gpshead @tiran @iritkatriel @miss-islington