Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test_start_new_session for posix_spawnp fails #80057

Closed
pablogsal opened this issue Feb 1, 2019 · 6 comments
Closed

test_start_new_session for posix_spawnp fails #80057

pablogsal opened this issue Feb 1, 2019 · 6 comments
Labels
3.8 only security fixes tests Tests in the Lib/test dir

Comments

@pablogsal
Copy link
Member

BPO 35876
Nosy @vstinner, @pablogsal, @miss-islington, @nanjekyejoannah
PRs
  • bpo-35537: Rewrite setsid test for os.posix_spawn #11721
  • [3.8] bpo-35537: Rewrite setsid test for os.posix_spawn (GH-11721) #14093
    		•

    Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.

    Show more details

    GitHub fields:

    assignee = None
closed_at = <Date 2019-06-14.17:35:33.053>
created_at = <Date 2019-02-01.10:53:19.435>
labels = ['3.8', 'tests']
title = 'test_start_new_session for posix_spawnp fails'
updated_at = <Date 2019-06-14.17:49:26.803>
user = 'https://github.com/pablogsal'

    bugs.python.org fields:

    activity = <Date 2019-06-14.17:49:26.803>
actor = 'miss-islington'
assignee = 'none'
closed = True
closed_date = <Date 2019-06-14.17:35:33.053>
closer = 'vstinner'
components = ['Tests']
creation = <Date 2019-02-01.10:53:19.435>
creator = 'pablogsal'
dependencies = []
files = []
hgrepos = []
issue_num = 35876
keywords = ['patch']
message_count = 6.0
messages = ['334664', '334666', '334668', '345618', '345619', '345622']
nosy_count = 4.0
nosy_names = ['vstinner', 'pablogsal', 'miss-islington', 'nanjekyejoannah']
pr_nums = ['11721', '14093']
priority = 'normal'
resolution = 'fixed'
stage = 'resolved'
status = 'closed'
superseder = None
type = None
url = 'https://bugs.python.org/issue35876'
versions = ['Python 3.8']
    @pablogsal
    Copy link
    Member Author

    Example failure:

    https://buildbot.python.org/all/#/builders/141/builds/1142/steps/4/logs/stdio

    =====================================================================
    ERROR: test_start_new_session (test.test_posix.TestPosixSpawn)
    ----------------------------------------------------------------------

    Traceback (most recent call last):
  File "/srv/buildbot/buildarea/3.x.bolen-ubuntu/build/Lib/test/test_posix.py", line 1640, in test_start_new_session
    child_pgid = int(output)
NameError: name 'output' is not defined

    ======================================================================
    ERROR: test_start_new_session (test.test_posix.TestPosixSpawnP)
    ----------------------------------------------------------------------

    Traceback (most recent call last):
  File "/srv/buildbot/buildarea/3.x.bolen-ubuntu/build/Lib/test/test_posix.py", line 1640, in test_start_new_session
    child_pgid = int(output)
NameError: name 'output' is not defined

    Victor made a PR to ignore the test for now:

    #11718

    This WIP PR intends to fix this bug:

    #11719

    @pablogsal pablogsal added 3.8 only security fixes tests Tests in the Lib/test dir labels Feb 1, 2019
    @vstinner
    Copy link
    Member

    vstinner commented Feb 1, 2019

    I skipped the test with commit 1e39b83.

    But the test still needs to be fixed.

    Joannah Nanjekye wrote the new test and I'm mentoring her, so I would prefer that she fix the test.

    @vstinner
    Copy link
    Member

    vstinner commented Feb 1, 2019

    Joannah Nanjekye wrote the new test and I'm mentoring her, so I would prefer that she fix the test.

    Oh wait, when I looked at the test, it's way more complex to implement that what I expected! So I decided to rewrite the test myself.

    @vstinner
    Copy link
    Member

    New changeset 5884043 by Victor Stinner in branch 'master':
    bpo-35537: Rewrite setsid test for os.posix_spawn (GH-11721)
    5884043

    @vstinner
    Copy link
    Member

    I rewrote and reenabled the test. It should now be fixed in master, and the 3.8 backport is coming soon.

    @miss-islington
    Copy link
    Contributor

    New changeset e696b15 by Miss Islington (bot) in branch '3.8':
    bpo-35537: Rewrite setsid test for os.posix_spawn (GH-11721)
    e696b15

    @ezio-melotti ezio-melotti transferred this issue from another repository Apr 10, 2022
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Assignees
    No one assigned
    Labels
    3.8 only security fixes tests Tests in the Lib/test dir
    Projects
    None yet
    Milestone
    No milestone
    Development

    No branches or pull requests
    3 participants
    @vstinner @pablogsal @miss-islington