-
-
Notifications
You must be signed in to change notification settings - Fork 29.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enable manylinux1 builds on Pipelines for CI testing #79864
Comments
Azure Pipelines can now support container jobs: https://docs.microsoft.com/en-us/azure/devops/pipelines/process/container-phases?view=vsts&tabs=yaml I experimented with enabling a manylinux1 build a while back, which should now be able to use identical steps to the POSIX build. With the new syntax, we can enable CI (and perhaps PR?) builds using the snippet below:
I don't have time right now to test this change, but someone else might. It's certainly going to be easier for someone to test it by adding this to the PR build first (or set up a build on your own Pipelines instance). Maybe there are other more relevant containers we should be testing in? |
I have made the changes I suggested (though correctly...), but ultimately we need to create our own Docker image suitable for running these tests. So for now, I'm proposing in my PR to make most of the change, as well as a few other Pipelines/test-related improvements, but to leave this open in case someone wants to come in later with a suitable image. At that point, the only change necessary to enable the tests will be to add a "posix_deps_yum.sh" script, update the image name/tag and change the manylinux variable to 'true'. PR 11493 also fixes a missing LICENSE.txt file in the app store package, which was causing an idlelib test to fail as the fallback text only has one line. *Way* too obscure a failure for my liking, but at least we had a test there, so thanks, Terry :) |
I believe it was Louie Lu's idea, bpo-30290, to check more than one line. |
As mentioned above, those changes are other improvements that were worth taking, and about half of the required manylinux1 changes. But we probably need to maintain our own manylinux image for building/running CPython tests, if we want to do it. The existing images are all designed for having CPython already present to build a range of binaries, which is not at all our use case. |
@zooba Issue seems have been resolved. Can we close the issue? |
Abandoned, rather than resolved, but I doubt we'll come back to it given the complexity of the space within manylinux these days. |
Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.
Show more details
GitHub fields:
bugs.python.org fields:
The text was updated successfully, but these errors were encountered: